Removed obsolete IOException #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rPraml
commented
Oct 2, 2024
| @@ -2513,8 +2501,7 @@ private ScriptNode parse( | |||
| int lineno, | |||
| CompilerEnvirons compilerEnv, | |||
| ErrorReporter compilationErrorReporter, | |||
| boolean returnFunction) | |||
| throws IOException { | |||
| boolean returnFunction) { | |||
There was a problem hiding this comment.
I assume, that in former time a Reader was passed instead of String sourceString and that's why the IOException was still there. It can be removed and in all depending calls also.
Note: This might be a breaking change, if someone has implemented his own context with overwritten compileImpl
|
fine for me i do not need backward compatibility here |
|
This is the kind of incompatibility I can live with. Thanks! |
p-bakker
added
the
Potentially Breaking Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a never thrown IO-Exception