Use UTF-8 decoding for java source files #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the default on Linux and Mac, but not on Windows. This should standardize across platforms.
|
Yes, I think this makes sense and is a better way to ensure our Windows builds work. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the default on Linux and Mac, but not on Windows. This should standardize across platforms. I believe this will also allow us to revert #1588.
Without ensuring that UTF-8 encoding is always expected, any characters in the java source with a code point above 127 will be read incorrectly by Windows. While we could escape all of those characters, one must remember to do it, and escaping those characters harms readability.