Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding LambdaAccessorSlot #1577

Merged
merged 10 commits into from
Aug 31, 2024
Merged

Adding LambdaAccessorSlot #1577

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4a27e8e
adding new type of Slot called OwnerAwareLambdaSlot, that allows defi…
nabacg Aug 7, 2024
e0af91a
Update tests/src/test/java/org/mozilla/javascript/tests/OwnerAwareLam…
nabacg Aug 22, 2024
d5cafc7
re-formating with spotlessApply
nabacg Aug 22, 2024
c4789fc
getValue to return null, not Undefined
nabacg Aug 22, 2024
e099931
OwnerAwareLambdaSlot -> LambdaAccessorSlot rename, plus making sure g…
nabacg Aug 23, 2024
b9c528b
Bringing LambdaAccessorSlot more in line with AccessSlot, making sure…
nabacg Aug 25, 2024
0d53988
spotlessApply
nabacg Aug 25, 2024
7369f3f
removing no longer used ensureLambdaAccessorSlot overload
nabacg Aug 27, 2024
323396f
updating outdated comment on defineProperty
nabacg Aug 28, 2024
a48d1c0
refactoring tests to use Utils.runWithAllOptimizationLevels
nabacg Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/src/test/java/org/mozilla/javascript/tests/OwnerAwareLambdaSlotTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public void testCanUpdateValueUsingSetter() {
Object setResult = cx.evaluateString(scope, "s.status = 'DONE';", "source", 1, null);

Object newStatus = cx.evaluateString(scope, "s.status", "source", 1, null);
assertEquals( "NewStatus: DONE", newStatus);
assertEquals("NewStatus: DONE", newStatus);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nabacg - this was only one change I noticed, that the code is not correctly indented/aligned.

There are several more, if you take a look at the last build: https://github.com/mozilla/rhino/actions/runs/10504907544/job/29103912052

You will need to fix this violations first with ./gradlew spotlessApply (You should not the "Format code" feature of your IDE)

If you need help, let me know

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure I've run ./gradlew spotlessApply before raising the PR, but now I see that I was running Java 17 and spotlessApply seems to do nothing? I switched to Java 11 and that made the difference d5cafc7.

I guess this is mentioned here, rookie mistake!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also happens to me in every new console window, when I've forgotten to change JAVA_HOME 🤣

}

@Test
Expand Down