Add Byte to list of java Numbers #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also see #996 |
|
This seems quite reasonable to me, but in most of the work I've done I haven't used the WrapFactory much. Is there any way to add a test for this functionality so that we could see the effect of a regression here, even if it ends up being just a test of that instanceof check? |
tonygermano
force-pushed
the
primitive_wrapper
branch
from
84179d3
to
54947e7
Compare
|
Test added. |
p-bakker
added
the
Java Interop
|
Great, and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it was just an oversight that
Bytewas missing from the list. Originally, it applied to all java.lang.Numbers.