Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Document that callables receive sanitized values #243

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

tdsmith
Copy link
Contributor

@tdsmith tdsmith commented Dec 2, 2018

Explain that replacing key="a-value" with key=lambda x: x in ("a-value", "b-value") will not work.

Explain that replacing `key="a-value"` with `key=lambda x: x
in ("a-value", "b-value")` will not work.
@tdsmith tdsmith requested a review from mreid-moz December 2, 2018 06:55
@codecov-io
Copy link

Codecov Report

Merging #243 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files          11       11           
  Lines        1053     1053           
=======================================
  Hits          843      843           
  Misses        210      210
Flag Coverage Δ
#py27 79.86% <ø> (ø) ⬆️
#py35 79.01% <ø> (ø) ⬆️
#py36 79.01% <ø> (ø) ⬆️
Impacted Files Coverage Δ
moztelemetry/dataset.py 95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f030ed...93ee93c. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #243 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files          11       11           
  Lines        1053     1053           
=======================================
  Hits          843      843           
  Misses        210      210
Flag Coverage Δ
#py27 79.86% <ø> (ø) ⬆️
#py35 79.01% <ø> (ø) ⬆️
#py36 79.01% <ø> (ø) ⬆️
Impacted Files Coverage Δ
moztelemetry/dataset.py 95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f030ed...93ee93c. Read the comment docs.

Copy link
Contributor

@mreid-moz mreid-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@mreid-moz mreid-moz merged commit 09ddf1e into mozilla:master Dec 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants