This repository has been archived by the owner on Nov 21, 2023. It is now read-only.
Fix some errors in API docs and link to DTMO #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
=======================================
Coverage 80.05% 80.05%
=======================================
Files 11 11
Lines 1053 1053
=======================================
Hits 843 843
Misses 210 210
Continue to review full report at Codecov.
|
jklukas
force-pushed
the
ghpages-docs
branch
2 times, most recently
from
d22bb8a to
5e21878
Compare
wlach
reviewed
Nov 2, 2018
README.md
Outdated
| Spark bindings for Mozilla Telemetry | ||
| PySpark bindings for Mozilla Telemetry | ||
|
|
||
| ## Usage |
There was a problem hiding this comment.
I think less is more for this section. Let's just do something like:
## Documentation
Online documentation is available at https://mozilla.github.io/python_moztelemetry/
That way if the dtmo link ever changes, we only need to update it in one place.
wlach
reviewed
Nov 2, 2018
docs/conf.py
Outdated
| @@ -55,17 +55,17 @@ | |||
|
|
|||
| # General information about the project. | |||
| project = u'python_moztelemetry' | |||
| copyright = u'2016, Mozilla Firefox Data Platform' | |||
| copyright = u'2016-2018, Mozilla Firefox Data Platform' | |||
There was a problem hiding this comment.
Can we just leave out the year? That piece of information always seems to go out of date
wlach
approved these changes
Nov 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.