Implement helper functions for (un)selecting an editor in the integration tests #19344
Conversation
timvandermeij
changed the title
timvandermeij
force-pushed
the
integration-tests-editor-helpers
branch
from
4c524ee to
2c1431a
Compare
The `selectorEditor` name is used 57 times, but only in the freetext editor integration tests file. The `editorSelector` name on the other hand is used 241 times in all editor integration test files, so this commit renames the former name to the latter name to achieve consistency in variable names across all editor integration test files, which also simplifies upcoming changes.
timvandermeij
force-pushed
the
integration-tests-editor-helpers
branch
from
2c1431a to
111368e
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5a9d5d355bb31d0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ff2de2410ef95e9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5a9d5d355bb31d0/output.txt Total script time: 11.38 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ff2de2410ef95e9/output.txt Total script time: 27.94 mins
|
timvandermeij
force-pushed
the
integration-tests-editor-helpers
branch
2 times, most recently
from
c6b934a to
3b13e44
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/46b2de0b78eda90/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/190b13f1301f5e2/output.txt |
…n tests This has multiple advantages: - it improves consistency between the various editor integration tests; - it makes the code easier to read/understand; - it reduces code duplication; - it reduces the number of `getEditorSelector` calls that contained hardcoded IDs, which helps to isolate the tests and to simplify follow-up patches.
…ion tests This has multiple advantages: - it improves consistency between the various editor integration tests; - it makes the code easier to read/understand; - it reduces code duplication.
timvandermeij
force-pushed
the
integration-tests-editor-helpers
branch
from
3b13e44 to
895edaf
Compare
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/46b2de0b78eda90/output.txt Total script time: 10.36 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/190b13f1301f5e2/output.txt Total script time: 26.30 mins
|
|
I just realized that the Linux failures were actually caused by a change in this patch because I could reproduce the issue locally. Initially I thought they were intermittents we had seen before, which shows that it's sadly still a bit easy to miss the introduction of new issues due to noise in the test results. Sorry for the oversight; with the upcoming patches and test isolation I hope to get that more under control and simplify the code to reduce room for error. Let's run the tests once more with the fixes applied, for good measure: /botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/678a1d8c55f3e46/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/36969269f697138/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/678a1d8c55f3e46/output.txt Total script time: 10.38 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/36969269f697138/output.txt Total script time: 26.20 mins
|
The commit messages contain more details about the individual changes.
Fixes a part of #19065.