Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with packet containing MAX_STREAM_DATA being lost #726

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

agrover
Copy link
Contributor

@agrover agrover commented Jun 15, 2020

If a packet is lost, always requeue the flow control update for sending.

fixes #720

@agrover agrover requested review from martinthomson and ddragana and removed request for ddragana June 15, 2020 17:27
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A question that is probably just a new issue and a suggestion for your comments.

If a packet is lost, always requeue the flow control update for sending.

fixes mozilla#720
@agrover
Copy link
Contributor Author

agrover commented Jun 16, 2020

manually merging based on martin's LGTM.

@agrover agrover merged commit 5f69e21 into mozilla:master Jun 16, 2020
@agrover agrover deleted the fix-720 branch June 16, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAX_STREAM_DATA is not resent if lost
2 participants