chore: Fix clippy warnings #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ans suppress some false positives, see rust-lang/rust-clippy#14091
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2453 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 115 115
Lines 36982 36982
Branches 36982 36982
=======================================
Hits 35280 35280
Misses 1696 1696
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 8821278. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 7005337. decode 4096 bytes, mask ff: No change in performance detected. time: [12.337 µs 12.382 µs 12.431 µs]
change: [-0.1271% +0.1645% +0.4735%] (p = 0.29 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [2.8325 ms 2.8402 ms 2.8493 ms]
change: [-0.7480% -0.2565% +0.2434%] (p = 0.31 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [20.850 µs 20.904 µs 20.963 µs]
change: [-0.5166% +0.0420% +0.6460%] (p = 0.90 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [4.5381 ms 4.5491 ms 4.5607 ms]
change: [-0.4485% -0.0783% +0.2725%] (p = 0.69 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [8.2642 µs 8.2965 µs 8.3342 µs]
change: [-0.1012% +0.3250% +0.9389%] (p = 0.24 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.5871 ms 1.5942 ms 1.6055 ms]
change: [-0.8726% -0.1643% +0.5547%] (p = 0.68 > 0.05)
1 streams of 1 bytes/multistream: No change in performance detected. time: [66.526 µs 67.065 µs 68.006 µs]
change: [-2.0161% +0.3337% +2.3222%] (p = 0.79 > 0.05)
1000 streams of 1 bytes/multistream: No change in performance detected. time: [24.273 ms 24.312 ms 24.351 ms]
change: [-0.2052% +0.0303% +0.2558%] (p = 0.79 > 0.05)
10000 streams of 1 bytes/multistream: Change within noise threshold. time: [1.6494 s 1.6514 s 1.6534 s]
change: [-0.5160% -0.3576% -0.1977%] (p = 0.00 < 0.05)
1 streams of 1000 bytes/multistream: No change in performance detected. time: [67.979 µs 68.528 µs 69.500 µs]
change: [-0.9758% +0.9180% +2.7807%] (p = 0.41 > 0.05)
100 streams of 1000 bytes/multistream: No change in performance detected. time: [3.2294 ms 3.2364 ms 3.2442 ms]
change: [-0.8205% -0.2878% +0.1732%] (p = 0.28 > 0.05)
1000 streams of 1000 bytes/multistream: No change in performance detected. time: [143.66 ms 143.82 ms 144.06 ms]
change: [-0.2399% -0.0277% +0.1750%] (p = 0.81 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [89.904 ns 90.220 ns 90.535 ns]
change: [-0.3426% +0.0796% +0.5192%] (p = 0.73 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [107.13 ns 107.41 ns 107.72 ns]
change: [-1.0183% -0.3545% +0.1773%] (p = 0.27 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [107.07 ns 107.97 ns 109.21 ns]
change: [-1.0296% +1.1419% +3.9332%] (p = 0.49 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [89.435 ns 89.585 ns 89.753 ns]
change: [-0.4425% +0.5105% +1.4067%] (p = 0.30 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [112.61 ms 112.75 ms 112.96 ms]
change: [-0.1526% +0.0779% +0.3351%] (p = 0.57 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.2342 µs 5.4147 µs 5.6086 µs]
change: [-16.663% -4.0216% +5.4104%] (p = 0.71 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [34.114 ms 34.175 ms 34.236 ms]
change: [+0.3240% +0.5822% +0.8193%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [34.313 ms 34.368 ms 34.425 ms]
change: [+0.1229% +0.3367% +0.5582%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [34.485 ms 34.541 ms 34.601 ms]
change: [+1.4605% +1.7124% +1.9530%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [34.088 ms 34.142 ms 34.203 ms]
change: [-1.4170% -1.2043% -0.9787%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [859.07 ms 868.93 ms 879.08 ms]
thrpt: [113.76 MiB/s 115.08 MiB/s 116.40 MiB/s]
change:
time: [-3.1523% -1.6005% -0.0116%] (p = 0.05 > 0.05)
thrpt: [+0.0116% +1.6266% +3.2549%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [315.92 ms 319.48 ms 323.07 ms]
thrpt: [30.953 Kelem/s 31.301 Kelem/s 31.654 Kelem/s]
change:
time: [-2.0261% -0.4158% +1.2316%] (p = 0.60 > 0.05)
thrpt: [-1.2166% +0.4175% +2.0680%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.519 ms 25.706 ms 25.900 ms]
thrpt: [38.610 elem/s 38.901 elem/s 39.187 elem/s]
change:
time: [-0.8875% +0.1412% +1.1015%] (p = 0.78 > 0.05)
thrpt: [-1.0895% -0.1410% +0.8955%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [1.8292 s 1.8455 s 1.8619 s]
thrpt: [53.709 MiB/s 54.187 MiB/s 54.670 MiB/s]
change:
time: [+0.9784% +2.2477% +3.6011%] (p = 0.00 < 0.05)
thrpt: [-3.4759% -2.1983% -0.9689%]
Client/server transfer resultsPerformance differences relative to 7005337. Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
martinthomson
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ans suppress some false positives, see rust-lang/rust-clippy#14091