chore: Use EnumSet instead of a Boolean EnumMap
#2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `PacketNumberSpaceSet`. May be faster?
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2443 +/- ##
==========================================
- Coverage 95.38% 95.38% -0.01%
==========================================
Files 115 115
Lines 37039 36972 -67
Branches 37039 36972 -67
==========================================
- Hits 35331 35265 -66
+ Misses 1702 1701 -1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to ef6e6f4. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
reviewed
Feb 13, 2025
Benchmark resultsPerformance differences relative to ef6e6f4. decode 4096 bytes, mask ff: 💔 Performance has regressed. time: [12.333 µs 12.374 µs 12.420 µs]
change: [+12.542% +13.405% +14.083%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask ff: 💚 Performance has improved. time: [3.0773 ms 3.0866 ms 3.0976 ms]
change: [-2.0897% -1.6349% -1.1741%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 7f: 💔 Performance has regressed. time: [20.861 µs 20.919 µs 20.982 µs]
change: [+17.678% +18.149% +18.614%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 7f: 💚 Performance has improved. time: [5.2144 ms 5.2274 ms 5.2421 ms]
change: [-3.6761% -3.3613% -2.9879%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 3f: 💔 Performance has regressed. time: [8.2731 µs 8.3090 µs 8.3504 µs]
change: [+26.172% +27.322% +28.990%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7581 ms 1.7597 ms 1.7626 ms]
change: [-0.0150% +0.0734% +0.2379%] (p = 0.54 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [91.202 ns 91.504 ns 91.805 ns]
change: [-0.3364% +1.1046% +3.6412%] (p = 0.44 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [109.76 ns 110.08 ns 110.45 ns]
change: [-0.0176% +0.3821% +0.8077%] (p = 0.09 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [109.55 ns 110.14 ns 110.88 ns]
change: [-0.7476% -0.1137% +0.4952%] (p = 0.72 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [93.058 ns 93.213 ns 93.393 ns]
change: [-1.2491% -0.0709% +1.1165%] (p = 0.92 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [112.29 ms 112.35 ms 112.41 ms]
change: [+0.6359% +0.7105% +0.7834%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.3655 µs 5.5525 µs 5.7643 µs]
change: [-1.3573% +1.8173% +5.2349%] (p = 0.27 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [33.929 ms 33.989 ms 34.051 ms]
change: [-1.1148% -0.8107% -0.5400%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.321 ms 34.379 ms 34.438 ms]
change: [-0.2753% +0.0260% +0.2918%] (p = 0.87 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [34.274 ms 34.322 ms 34.370 ms]
change: [-0.6189% -0.4043% -0.1984%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [34.701 ms 34.763 ms 34.827 ms]
change: [-0.1675% +0.0851% +0.3313%] (p = 0.50 > 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [838.77 ms 849.14 ms 859.87 ms]
thrpt: [116.30 MiB/s 117.77 MiB/s 119.22 MiB/s]
change:
time: [-2.5056% -0.8090% +0.9863%] (p = 0.37 > 0.05)
thrpt: [-0.9767% +0.8156% +2.5700%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [317.73 ms 321.28 ms 324.83 ms]
thrpt: [30.786 Kelem/s 31.125 Kelem/s 31.474 Kelem/s]
change:
time: [-0.9502% +0.6350% +2.1760%] (p = 0.42 > 0.05)
thrpt: [-2.1297% -0.6310% +0.9593%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.460 ms 25.642 ms 25.833 ms]
thrpt: [38.710 elem/s 38.998 elem/s 39.278 elem/s]
change:
time: [-1.1723% -0.1472% +0.8656%] (p = 0.78 > 0.05)
thrpt: [-0.8582% +0.1474% +1.1862%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [1.8519 s 1.8721 s 1.8923 s]
thrpt: [52.846 MiB/s 53.417 MiB/s 53.998 MiB/s]
change:
time: [-2.3665% -1.0208% +0.3778%] (p = 0.16 > 0.05)
thrpt: [-0.3764% +1.0313% +2.4238%]
Client/server transfer resultsPerformance differences relative to ef6e6f4. Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
martinthomson
approved these changes
Feb 13, 2025
mxinden
approved these changes
Feb 14, 2025
Signed-off-by: Lars Eggert <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
PacketNumberSpaceSet. May be faster?