ci: Fix QNS log failure #2425
Merged
ci: Fix QNS log failure #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hate GitHub CI
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2425 +/- ##
==========================================
- Coverage 95.28% 95.28% -0.01%
==========================================
Files 114 114
Lines 37111 37098 -13
Branches 37111 37098 -13
==========================================
- Hits 35363 35349 -14
- Misses 1742 1743 +1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 9dec573. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 9dec573. decode 4096 bytes, mask ff: No change in performance detected. time: [10.864 µs 10.901 µs 10.943 µs]
change: [-1.0945% -0.3348% +0.3105%] (p = 0.38 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.1291 ms 3.1385 ms 3.1495 ms]
change: [-1.2491% -0.2355% +0.4950%] (p = 0.66 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [17.633 µs 17.693 µs 17.763 µs]
change: [-0.5128% +0.3807% +1.5574%] (p = 0.54 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.3995 ms 5.4105 ms 5.4231 ms]
change: [-0.8925% -0.2408% +0.2311%] (p = 0.46 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [6.6768 µs 6.7064 µs 6.7391 µs]
change: [-0.3870% +0.4819% +1.3206%] (p = 0.28 > 0.05)
decode 1048576 bytes, mask 3f: Change within noise threshold. time: [1.7583 ms 1.7608 ms 1.7646 ms]
change: [-1.8648% -1.2525% -0.6487%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [91.281 ns 91.625 ns 91.961 ns]
change: [-0.3416% +0.2149% +0.8080%] (p = 0.48 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [109.36 ns 109.67 ns 110.02 ns]
change: [-0.3262% +0.0778% +0.4946%] (p = 0.71 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [109.03 ns 109.53 ns 110.11 ns]
change: [-0.0305% +0.2751% +0.6745%] (p = 0.14 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [93.125 ns 93.306 ns 93.511 ns]
change: [-1.2707% -0.3294% +0.5619%] (p = 0.51 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [112.00 ms 112.06 ms 112.13 ms]
change: [+0.0499% +0.1279% +0.2030%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.1778 µs 5.2597 µs 5.3393 µs]
change: [-17.149% -5.2195% +3.4964%] (p = 0.57 > 0.05)
transfer/pacing-false/varying-seeds: 💔 Performance has regressed. time: [39.679 ms 39.761 ms 39.855 ms]
change: [+6.1184% +6.4379% +6.7898%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: 💔 Performance has regressed. time: [39.930 ms 40.004 ms 40.078 ms]
change: [+6.9239% +7.2173% +7.5036%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: 💔 Performance has regressed. time: [39.804 ms 39.877 ms 39.953 ms]
change: [+6.4291% +6.7564% +7.0871%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💔 Performance has regressed. time: [40.067 ms 40.138 ms 40.215 ms]
change: [+6.8473% +7.1451% +7.4284%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [845.58 ms 855.64 ms 866.07 ms]
thrpt: [115.46 MiB/s 116.87 MiB/s 118.26 MiB/s]
change:
time: [-0.8945% +0.7594% +2.4705%] (p = 0.37 > 0.05)
thrpt: [-2.4109% -0.7536% +0.9025%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: Change within noise threshold. time: [318.45 ms 321.73 ms 325.03 ms]
thrpt: [30.766 Kelem/s 31.082 Kelem/s 31.402 Kelem/s]
change:
time: [+0.2436% +1.7503% +3.1980%] (p = 0.02 < 0.05)
thrpt: [-3.0989% -1.7202% -0.2430%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.506 ms 25.659 ms 25.812 ms]
thrpt: [38.742 elem/s 38.973 elem/s 39.206 elem/s]
change:
time: [-0.8059% +0.0965% +0.9158%] (p = 0.82 > 0.05)
thrpt: [-0.9075% -0.0964% +0.8124%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [1.9186 s 1.9371 s 1.9555 s]
thrpt: [51.137 MiB/s 51.623 MiB/s 52.122 MiB/s]
change:
time: [-0.0871% +1.4273% +2.9785%] (p = 0.06 > 0.05)
thrpt: [-2.8924% -1.4072% +0.0872%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback, 20 runs.
|
larseggert
commented
Feb 6, 2025
| @@ -112,9 +112,8 @@ runs: | |||
| env: | |||
| ARTIFACT_URL: ${{ steps.upload-logs.outputs.artifact-url }} | |||
| run: | | |||
| jq ". + {log_url: \"$ARTIFACT_URL\"}" | |||
There was a problem hiding this comment.
The whole issue is due to the missing backslash in this line 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, fixed. I managed to accidentally remove a backslash, which caused everything to explode. Put it back.
Also did a little bonus maintenance while I was here, by adding
tquicandopensslto the interop matrix, and by using the correct highlighting for lines normally hidden under "All results".I still hate GitHub CI.