-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Disable arm64
docker image build
#2416
Conversation
Because `gcc` on `arm64` segfaults. Yay. Also don't run QNS on push to `main` to save some cycles.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2416 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 114 114
Lines 37111 37111
Branches 37111 37111
=======================================
Hits 35363 35363
Misses 1742 1742
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 108fb8d. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsNone ❓ Unsupported Interop TestsNone ❓ |
Benchmark resultsPerformance differences relative to 45e6d5c. decode 4096 bytes, mask ff: No change in performance detected.time: [11.814 µs 11.855 µs 11.902 µs] change: [-0.4269% +0.2743% +1.0700%] (p = 0.48 > 0.05) decode 1048576 bytes, mask ff: No change in performance detected.time: [2.9018 ms 2.9110 ms 2.9216 ms] change: [-0.3411% +0.1226% +0.5755%] (p = 0.60 > 0.05) decode 4096 bytes, mask 7f: No change in performance detected.time: [19.699 µs 19.753 µs 19.813 µs] change: [-1.4981% -0.5604% +0.1606%] (p = 0.21 > 0.05) decode 1048576 bytes, mask 7f: No change in performance detected.time: [4.7138 ms 4.7265 ms 4.7410 ms] change: [-0.5404% -0.1126% +0.2459%] (p = 0.60 > 0.05) decode 4096 bytes, mask 3f: No change in performance detected.time: [6.2154 µs 6.2427 µs 6.2770 µs] change: [-0.5415% +0.1125% +0.7874%] (p = 0.76 > 0.05) decode 1048576 bytes, mask 3f: No change in performance detected.time: [2.1151 ms 2.1221 ms 2.1304 ms] change: [-0.3313% +0.1274% +0.6503%] (p = 0.63 > 0.05) coalesce_acked_from_zero 1+1 entries: No change in performance detected.time: [93.253 ns 93.531 ns 93.809 ns] change: [-0.6078% +0.0487% +0.7436%] (p = 0.89 > 0.05) coalesce_acked_from_zero 3+1 entries: No change in performance detected.time: [110.85 ns 111.26 ns 111.71 ns] change: [-0.1800% +0.3090% +0.8366%] (p = 0.25 > 0.05) coalesce_acked_from_zero 10+1 entries: No change in performance detected.time: [110.31 ns 110.67 ns 111.14 ns] change: [-0.4691% +0.6018% +2.4964%] (p = 0.56 > 0.05) coalesce_acked_from_zero 1000+1 entries: No change in performance detected.time: [92.697 ns 92.846 ns 93.037 ns] change: [-1.9780% -0.3572% +0.9418%] (p = 0.68 > 0.05) RxStreamOrderer::inbound_frame(): Change within noise threshold.time: [111.84 ms 111.90 ms 111.95 ms] change: [-0.6055% -0.4036% -0.2692%] (p = 0.00 < 0.05) SentPackets::take_ranges: No change in performance detected.time: [5.1581 µs 5.2349 µs 5.3069 µs] change: [-2.5442% -0.1726% +2.2512%] (p = 0.89 > 0.05) transfer/pacing-false/varying-seeds: Change within noise threshold.time: [36.983 ms 37.072 ms 37.163 ms] change: [-2.4016% -2.1125% -1.8040%] (p = 0.00 < 0.05) transfer/pacing-true/varying-seeds: Change within noise threshold.time: [37.054 ms 37.127 ms 37.208 ms] change: [-2.7774% -2.5232% -2.2490%] (p = 0.00 < 0.05) transfer/pacing-false/same-seed: Change within noise threshold.time: [36.869 ms 36.959 ms 37.053 ms] change: [-2.5045% -2.1971% -1.8797%] (p = 0.00 < 0.05) transfer/pacing-true/same-seed: Change within noise threshold.time: [36.901 ms 36.982 ms 37.071 ms] change: [-3.2313% -2.9712% -2.7030%] (p = 0.00 < 0.05) 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected.time: [839.76 ms 849.98 ms 860.51 ms] thrpt: [116.21 MiB/s 117.65 MiB/s 119.08 MiB/s] change: time: [-2.2036% -0.6419% +0.9739%] (p = 0.43 > 0.05) thrpt: [-0.9645% +0.6461% +2.2532%] 1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.time: [319.70 ms 323.19 ms 326.71 ms] thrpt: [30.608 Kelem/s 30.941 Kelem/s 31.280 Kelem/s] change: time: [-1.2010% +0.2079% +1.6526%] (p = 0.79 > 0.05) thrpt: [-1.6257% -0.2075% +1.2156%] 1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.time: [25.439 ms 25.593 ms 25.748 ms] thrpt: [38.838 elem/s 39.073 elem/s 39.309 elem/s] change: time: [-1.0712% -0.2667% +0.5920%] (p = 0.53 > 0.05) thrpt: [-0.5885% +0.2674% +1.0828%] 1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold.time: [1.8106 s 1.8280 s 1.8457 s] thrpt: [54.179 MiB/s 54.704 MiB/s 55.231 MiB/s] change: time: [-3.5641% -2.1183% -0.7251%] (p = 0.00 < 0.05) thrpt: [+0.7304% +2.1641% +3.6958%] Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Because
gcc
onarm64
segfaults. Yay.Also don't run QNS on push to
main
to save some cycles.