Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable arm64 docker image build #2416

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

larseggert
Copy link
Collaborator

Because gcc on arm64 segfaults. Yay.

Also don't run QNS on push to main to save some cycles.

Because `gcc` on `arm64` segfaults. Yay.

Also don't run QNS on push to `main` to save some cycles.
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (45e6d5c) to head (3717611).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2416   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files         114      114           
  Lines       37111    37111           
  Branches    37111    37111           
=======================================
  Hits        35363    35363           
  Misses       1742     1742           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 4, 2025

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to 108fb8d.

neqo-latest as client

  • neqo-latest vs. xquic: run cancelled after min

neqo-latest as server

  • lsquic vs. neqo-latest: run cancelled after min
  • mvfst vs. neqo-latest: run cancelled after min
  • ngtcp2 vs. neqo-latest: run cancelled after min
All results

Succeeded Interop Tests

None ❓

Unsupported Interop Tests

None ❓

Copy link

github-actions bot commented Feb 4, 2025

Benchmark results

Performance differences relative to 45e6d5c.

decode 4096 bytes, mask ff: No change in performance detected.
       time:   [11.814 µs 11.855 µs 11.902 µs]
       change: [-0.4269% +0.2743% +1.0700%] (p = 0.48 > 0.05)

Found 19 outliers among 100 measurements (19.00%)
1 (1.00%) low severe
4 (4.00%) low mild
14 (14.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [2.9018 ms 2.9110 ms 2.9216 ms]
       change: [-0.3411% +0.1226% +0.5755%] (p = 0.60 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
9 (9.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [19.699 µs 19.753 µs 19.813 µs]
       change: [-1.4981% -0.5604% +0.1606%] (p = 0.21 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
1 (1.00%) low severe
1 (1.00%) low mild
3 (3.00%) high mild
13 (13.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [4.7138 ms 4.7265 ms 4.7410 ms]
       change: [-0.5404% -0.1126% +0.2459%] (p = 0.60 > 0.05)

Found 12 outliers among 100 measurements (12.00%)
12 (12.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [6.2154 µs 6.2427 µs 6.2770 µs]
       change: [-0.5415% +0.1125% +0.7874%] (p = 0.76 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
3 (3.00%) high mild
7 (7.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.
       time:   [2.1151 ms 2.1221 ms 2.1304 ms]
       change: [-0.3313% +0.1274% +0.6503%] (p = 0.63 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
9 (9.00%) high severe

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [93.253 ns 93.531 ns 93.809 ns]
       change: [-0.6078% +0.0487% +0.7436%] (p = 0.89 > 0.05)

Found 12 outliers among 100 measurements (12.00%)
10 (10.00%) high mild
2 (2.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [110.85 ns 111.26 ns 111.71 ns]
       change: [-0.1800% +0.3090% +0.8366%] (p = 0.25 > 0.05)

Found 21 outliers among 100 measurements (21.00%)
4 (4.00%) low mild
2 (2.00%) high mild
15 (15.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [110.31 ns 110.67 ns 111.14 ns]
       change: [-0.4691% +0.6018% +2.4964%] (p = 0.56 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
3 (3.00%) low severe
2 (2.00%) low mild
6 (6.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [92.697 ns 92.846 ns 93.037 ns]
       change: [-1.9780% -0.3572% +0.9418%] (p = 0.68 > 0.05)

Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) high mild
4 (4.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.84 ms 111.90 ms 111.95 ms]
       change: [-0.6055% -0.4036% -0.2692%] (p = 0.00 < 0.05)

Found 11 outliers among 100 measurements (11.00%)
7 (7.00%) low mild
4 (4.00%) high mild

SentPackets::take_ranges: No change in performance detected.
       time:   [5.1581 µs 5.2349 µs 5.3069 µs]
       change: [-2.5442% -0.1726% +2.2512%] (p = 0.89 > 0.05)

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severe

transfer/pacing-false/varying-seeds: Change within noise threshold.
       time:   [36.983 ms 37.072 ms 37.163 ms]
       change: [-2.4016% -2.1125% -1.8040%] (p = 0.00 < 0.05)

Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) low mild
2 (2.00%) high mild
1 (1.00%) high severe

transfer/pacing-true/varying-seeds: Change within noise threshold.
       time:   [37.054 ms 37.127 ms 37.208 ms]
       change: [-2.7774% -2.5232% -2.2490%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [36.869 ms 36.959 ms 37.053 ms]
       change: [-2.5045% -2.1971% -1.8797%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) low mild
1 (1.00%) high severe

transfer/pacing-true/same-seed: Change within noise threshold.
       time:   [36.901 ms 36.982 ms 37.071 ms]
       change: [-3.2313% -2.9712% -2.7030%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected.
       time:   [839.76 ms 849.98 ms 860.51 ms]
       thrpt:  [116.21 MiB/s 117.65 MiB/s 119.08 MiB/s]
change:
       time:   [-2.2036% -0.6419% +0.9739%] (p = 0.43 > 0.05)
       thrpt:  [-0.9645% +0.6461% +2.2532%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [319.70 ms 323.19 ms 326.71 ms]
       thrpt:  [30.608 Kelem/s 30.941 Kelem/s 31.280 Kelem/s]
change:
       time:   [-1.2010% +0.2079% +1.6526%] (p = 0.79 > 0.05)
       thrpt:  [-1.6257% -0.2075% +1.2156%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.
       time:   [25.439 ms 25.593 ms 25.748 ms]
       thrpt:  [38.838  elem/s 39.073  elem/s 39.309  elem/s]
change:
       time:   [-1.0712% -0.2667% +0.5920%] (p = 0.53 > 0.05)
       thrpt:  [-0.5885% +0.2674% +1.0828%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold.
       time:   [1.8106 s 1.8280 s 1.8457 s]
       thrpt:  [54.179 MiB/s 54.704 MiB/s 55.231 MiB/s]
change:
       time:   [-3.5641% -2.1183% -0.7251%] (p = 0.00 < 0.05)
       thrpt:  [+0.7304% +2.1641% +3.6958%]

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing MTU Mean [ms] Min [ms] Max [ms]
gquiche gquiche 1504 532.7 ± 41.5 502.3 610.3
neqo gquiche reno on 1504 779.0 ± 81.7 725.1 974.6
neqo gquiche reno 1504 753.0 ± 19.2 732.7 788.3
neqo gquiche cubic on 1504 749.3 ± 30.4 707.0 818.0
neqo gquiche cubic 1504 725.3 ± 7.6 715.2 739.0
msquic msquic 1504 100.1 ± 8.8 91.6 118.4
neqo msquic reno on 1504 286.6 ± 145.1 199.1 686.6
neqo msquic reno 1504 203.0 ± 8.0 195.8 220.3
neqo msquic cubic on 1504 204.7 ± 9.1 195.7 223.3
neqo msquic cubic 1504 206.3 ± 10.0 196.7 222.9
gquiche neqo reno on 1504 641.5 ± 80.8 527.5 762.4
gquiche neqo reno 1504 711.0 ± 174.8 514.4 1115.8
gquiche neqo cubic on 1504 637.7 ± 87.4 529.6 757.2
gquiche neqo cubic 1504 645.7 ± 80.6 527.4 763.5
msquic neqo reno on 1504 458.4 ± 53.1 431.0 606.4
msquic neqo reno 1504 435.1 ± 22.0 414.9 490.0
msquic neqo cubic on 1504 444.5 ± 34.0 418.7 533.6
msquic neqo cubic 1504 477.4 ± 66.8 430.8 616.3
neqo neqo reno on 1504 429.0 ± 27.1 406.7 500.2
neqo neqo reno 1504 423.2 ± 13.5 402.7 445.3
neqo neqo cubic on 1504 495.9 ± 96.2 426.6 712.7
neqo neqo cubic 1504 434.3 ± 31.3 407.1 517.4

⬇️ Download logs

@larseggert larseggert merged commit 6a162e0 into mozilla:main Feb 4, 2025
68 of 72 checks passed
@larseggert larseggert deleted the ci-qns-no-arm64 branch February 4, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant