Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clippy +nightly --fix #2398

Merged
merged 1 commit into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions neqo-http3/src/connection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -727,13 +727,13 @@ impl Http3Connection {
match conn.stream_fairness(stream_id, true) {
Ok(()) | Err(neqo_transport::Error::InvalidStreamId) => (),
Err(e) => return Err(Error::from(e)),
};
}
qinfo!("[{self}] A new WebTransport stream {stream_id} for session {session_id}");
}
NewStreamType::Unknown => {
conn.stream_stop_sending(stream_id, Error::HttpStreamCreation.code())?;
}
};
}

match stream_type {
NewStreamType::Control | NewStreamType::Decoder | NewStreamType::Encoder => {
Expand Down
14 changes: 7 additions & 7 deletions neqo-http3/src/connection_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1304,7 +1304,7 @@ mod tests {
assert_eq!(err, CloseReason::Application(expected.code()));
}
_ => panic!("Wrong state {:?}", client.state()),
};
}
}

/// Create a http3 client with default configuration.
Expand Down Expand Up @@ -3675,7 +3675,7 @@ mod tests {
panic!("We should not receive a DataGeadable event!");
}
_ => {}
};
}
}

// ok NOW send fin
Expand All @@ -3699,7 +3699,7 @@ mod tests {
assert!(fin);
}
_ => {}
};
}
}

// Stream should now be closed and gone
Expand Down Expand Up @@ -3751,7 +3751,7 @@ mod tests {
assert_eq!(Ok((0, true)), client.read_data(now(), stream_id, &mut buf));
}
_ => {}
};
}
}

// Stream should now be closed and gone
Expand Down Expand Up @@ -3800,7 +3800,7 @@ mod tests {
panic!("We should not receive a DataGeadable event!");
}
_ => {}
};
}
}

// ok NOW send fin
Expand All @@ -3824,7 +3824,7 @@ mod tests {
assert!(fin);
}
_ => {}
};
}
}

// Stream should now be closed and gone
Expand Down Expand Up @@ -3871,7 +3871,7 @@ mod tests {
assert!(!fin);
}
_ => {}
};
}
}

// ok NOW send fin
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,5 +270,5 @@ fn wrong_setting_value() {
assert_eq!(err, CloseReason::Application(Error::HttpSettings.code()));
}
_ => panic!("Wrong state {:?}", client.state()),
};
}
}
2 changes: 1 addition & 1 deletion neqo-http3/src/frames/tests/reader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ fn test_reading_frame<T: FrameDecoder<T> + PartialEq + Debug>(
assert!(fin);
assert!(f.is_none());
}
};
}
}

#[test]
Expand Down
2 changes: 1 addition & 1 deletion neqo-http3/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ impl Error {
_ => {
debug_assert!(false, "Unexpected error");
}
};
}
Self::TransportStreamDoesNotExist
}

Expand Down
4 changes: 2 additions & 2 deletions neqo-http3/src/recv_message.rs
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ impl RecvMessage {
break self.set_state_to_close_pending(post_readable_event);
}
}
};
}
}
RecvMessageState::DecodingHeaders { header_block, fin } => {
if self
Expand Down Expand Up @@ -338,7 +338,7 @@ impl RecvMessage {
// WebTransportSession
break Ok(());
}
};
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion neqo-http3/src/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ impl HSettings {
// other supported settings here
(Some(_), Some(_)) => {} // ignore unknown setting, it is fine.
_ => return Err(Error::NotEnoughData),
};
}
}
Ok(())
}
Expand Down
Loading