ci: Run cargo-deny during ci
#2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2340 +/- ##
==========================================
+ Coverage 93.01% 95.29% +2.28%
==========================================
Files 114 114
Lines 36844 36844
Branches 36844 36844
==========================================
+ Hits 34270 35111 +841
+ Misses 1796 1727 -69
+ Partials 778 6 -772 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 085fa62. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
reviewed
Jan 13, 2025
Benchmark resultsPerformance differences relative to 085fa62. decode 4096 bytes, mask ff: No change in performance detected. time: [11.173 µs 11.214 µs 11.260 µs]
change: [-0.2279% +0.9302% +2.8330%] (p = 0.33 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0172 ms 3.0263 ms 3.0368 ms]
change: [-1.0661% -0.3697% +0.2125%] (p = 0.27 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.509 µs 19.555 µs 19.607 µs]
change: [-0.4173% -0.1342% +0.1507%] (p = 0.37 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1611 ms 5.1740 ms 5.1888 ms]
change: [-1.3122% -0.3914% +0.2599%] (p = 0.40 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5296 µs 5.5467 µs 5.5708 µs]
change: [-0.4717% +0.1799% +0.9969%] (p = 0.65 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7593 ms 1.7665 ms 1.7779 ms]
change: [-0.0052% +0.4690% +1.1034%] (p = 0.08 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.902 ns 99.180 ns 99.473 ns]
change: [-0.4028% +0.0789% +0.6283%] (p = 0.79 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.82 ns 117.20 ns 117.61 ns]
change: [-0.5490% +0.1012% +0.8129%] (p = 0.79 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.35 ns 116.82 ns 117.38 ns]
change: [-0.5582% -0.0984% +0.3644%] (p = 0.68 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [96.940 ns 97.070 ns 97.233 ns]
change: [-1.1387% -0.3182% +0.5344%] (p = 0.49 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.15 ms 111.28 ms 111.49 ms]
change: [-0.2159% -0.0167% +0.2077%] (p = 0.89 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4691 µs 5.6527 µs 5.8481 µs]
change: [-3.0894% -0.3389% +2.5986%] (p = 0.81 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [41.643 ms 41.723 ms 41.804 ms]
change: [-0.5981% -0.3109% -0.0521%] (p = 0.03 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [41.649 ms 41.720 ms 41.790 ms]
change: [-1.0793% -0.8032% -0.5419%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [41.619 ms 41.677 ms 41.738 ms]
change: [-1.0263% -0.8134% -0.6003%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [41.533 ms 41.611 ms 41.697 ms]
change: [+0.0269% +0.3007% +0.5509%] (p = 0.03 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved. time: [871.21 ms 880.29 ms 889.76 ms]
thrpt: [112.39 MiB/s 113.60 MiB/s 114.78 MiB/s]
change:
time: [-6.3251% -4.9075% -3.3873%] (p = 0.00 < 0.05)
thrpt: [+3.5060% +5.1608% +6.7522%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [316.08 ms 318.48 ms 321.02 ms]
thrpt: [31.151 Kelem/s 31.399 Kelem/s 31.637 Kelem/s]
change:
time: [-1.1781% -0.0925% +0.9610%] (p = 0.86 > 0.05)
thrpt: [-0.9519% +0.0926% +1.1922%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.163 ms 34.334 ms 34.523 ms]
thrpt: [28.966 elem/s 29.125 elem/s 29.271 elem/s]
change:
time: [-0.6592% +0.0616% +0.8311%] (p = 0.87 > 0.05)
thrpt: [-0.8242% -0.0616% +0.6636%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [1.6777 s 1.6958 s 1.7137 s]
thrpt: [58.355 MiB/s 58.970 MiB/s 59.604 MiB/s]
change:
time: [-2.2139% -0.7700% +0.6913%] (p = 0.28 > 0.05)
thrpt: [-0.6866% +0.7760% +2.2640%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Jan 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oh wow, an action that is actually already allowlisted :-)