feat: Support QNS connectionmigration test
#2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2180 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 112 112
Lines 36373 36373
=======================================
Hits 34697 34697
Misses 1676 1676 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 66b9c8c. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.376 ns 99.708 ns 100.04 ns]
change: [-0.9157% -0.2130% +0.3690%] (p = 0.56 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.39 ns 117.77 ns 118.16 ns]
change: [-1.2181% -0.5815% -0.0346%] (p = 0.05 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.91 ns 117.31 ns 117.81 ns]
change: [-0.5088% -0.1948% +0.1170%] (p = 0.24 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [98.539 ns 98.684 ns 98.829 ns]
change: [-0.5799% +0.3254% +1.1335%] (p = 0.48 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [112.27 ms 112.33 ms 112.38 ms]
change: [+0.3757% +0.4447% +0.5150%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.738 ms 27.749 ms 28.765 ms]
change: [-6.8547% -1.7598% +4.1085%] (p = 0.53 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [35.635 ms 37.211 ms 38.812 ms]
change: [-1.0810% +5.0809% +11.493%] (p = 0.12 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [25.818 ms 26.624 ms 27.455 ms]
change: [-3.0176% +1.3612% +6.1322%] (p = 0.56 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [39.711 ms 41.488 ms 43.321 ms]
change: [-5.6324% +0.3485% +7.0216%] (p = 0.92 > 0.05)
1-conn/1-100mb-resp/mtu-1500 (aka. Download)/client: 💔 Performance has regressed. time: [890.32 ms 898.72 ms 907.43 ms]
thrpt: [110.20 MiB/s 111.27 MiB/s 112.32 MiB/s]
change:
time: [+1.4766% +2.7680% +4.1350%] (p = 0.00 < 0.05)
thrpt: [-3.9708% -2.6934% -1.4551%]
1-conn/10_000-parallel-1b-resp/mtu-1500 (aka. RPS)/client: Change within noise threshold. time: [316.87 ms 319.91 ms 323.01 ms]
thrpt: [30.959 Kelem/s 31.259 Kelem/s 31.559 Kelem/s]
change:
time: [+0.3549% +1.7564% +3.1081%] (p = 0.01 < 0.05)
thrpt: [-3.0144% -1.7261% -0.3536%]
1-conn/1-1b-resp/mtu-1500 (aka. HPS)/client: No change in performance detected. time: [33.677 ms 33.856 ms 34.048 ms]
thrpt: [29.370 elem/s 29.537 elem/s 29.694 elem/s]
change:
time: [-0.7217% +0.1127% +0.9351%] (p = 0.80 > 0.05)
thrpt: [-0.9264% -0.1125% +0.7270%]
1-conn/1-100mb-resp/mtu-65536 (aka. Download)/client: No change in performance detected. time: [113.22 ms 114.04 ms 115.25 ms]
thrpt: [867.69 MiB/s 876.91 MiB/s 883.26 MiB/s]
change:
time: [-0.1008% +0.8294% +2.0005%] (p = 0.13 > 0.05)
thrpt: [-1.9612% -0.8226% +0.1009%]
1-conn/10_000-parallel-1b-resp/mtu-65536 (aka. RPS)/client: No change in performance detected. time: [313.66 ms 316.80 ms 319.90 ms]
thrpt: [31.260 Kelem/s 31.565 Kelem/s 31.882 Kelem/s]
change:
time: [-1.4563% +0.0971% +1.6301%] (p = 0.90 > 0.05)
thrpt: [-1.6039% -0.0970% +1.4778%]
1-conn/1-1b-resp/mtu-65536 (aka. HPS)/client: No change in performance detected. time: [33.836 ms 34.053 ms 34.307 ms]
thrpt: [29.149 elem/s 29.366 elem/s 29.555 elem/s]
change:
time: [-0.0274% +0.8327% +1.7538%] (p = 0.07 > 0.05)
thrpt: [-1.7236% -0.8258% +0.0274%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
reviewed
Oct 16, 2024
martinthomson
approved these changes
Oct 21, 2024
Co-authored-by: Martin Thomson <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Co-authored-by: Martin Thomson <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Co-authored-by: Martin Thomson <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Co-authored-by: Martin Thomson <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.