Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump actions/upload-artifact from 4.4.0 to 4.4.3 #2174

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 14, 2024

Bumps actions/upload-artifact from 4.4.0 to 4.4.3.

Release notes

Sourced from actions/upload-artifact's releases.

v4.4.3

What's Changed

Full Changelog: actions/upload-artifact@v4.4.2...v4.4.3

v4.4.2

What's Changed

Full Changelog: actions/upload-artifact@v4.4.1...v4.4.2

v4.4.1

What's Changed

New Contributors

Full Changelog: actions/upload-artifact@v4.4.0...v4.4.1

Commits
  • b4b15b8 Merge pull request #632 from actions/joshmgross/undo-dependency-changes
  • 92b01eb Undo indirect dependency updates from #627
  • 8448086 Merge pull request #627 from actions/robherley/v4.4.2
  • b1d4642 add explicit relative and absolute symlinks to workflow
  • d50e660 bump version
  • aabe6f8 build with @​actions/artifact v2.1.11
  • 604373d Merge pull request #625 from actions/robherley/artifact-2.1.10
  • 0150148 paste right core version
  • a009b25 update licenses
  • 9f6f6f4 update @​actions/core and @​actions/artifact to latest versions
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

github-actions bot commented Oct 14, 2024

Benchmark results

Performance differences relative to 944c817.

coalesce_acked_from_zero 1+1 entries: Change within noise threshold.
       time:   [98.793 ns 99.163 ns 99.548 ns]
       change: [-1.5871% -0.9207% -0.3049%] (p = 0.00 < 0.05)

Found 12 outliers among 100 measurements (12.00%)
8 (8.00%) high mild
4 (4.00%) high severe

coalesce_acked_from_zero 3+1 entries: Change within noise threshold.
       time:   [116.48 ns 116.73 ns 117.02 ns]
       change: [-1.3070% -0.9402% -0.6173%] (p = 0.00 < 0.05)

Found 13 outliers among 100 measurements (13.00%)
1 (1.00%) low mild
4 (4.00%) high mild
8 (8.00%) high severe

coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [116.04 ns 116.30 ns 116.64 ns]
       change: [-1.3482% -0.8037% -0.2511%] (p = 0.00 < 0.05)

Found 17 outliers among 100 measurements (17.00%)
5 (5.00%) low severe
2 (2.00%) low mild
5 (5.00%) high mild
5 (5.00%) high severe

coalesce_acked_from_zero 1000+1 entries: Change within noise threshold.
       time:   [97.159 ns 97.319 ns 97.484 ns]
       change: [-2.1391% -1.2587% -0.4091%] (p = 0.00 < 0.05)

Found 9 outliers among 100 measurements (9.00%)
5 (5.00%) high mild
4 (4.00%) high severe

RxStreamOrderer::inbound_frame(): 💚 Performance has improved.
       time:   [110.96 ms 111.03 ms 111.11 ms]
       change: [-2.4833% -2.4096% -2.3310%] (p = 0.00 < 0.05)

Found 22 outliers among 100 measurements (22.00%)
11 (11.00%) low mild
7 (7.00%) high mild
4 (4.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.133 ms 27.212 ms 28.288 ms]
       change: [-7.1981% -2.1034% +3.1220%] (p = 0.45 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [34.542 ms 36.100 ms 37.639 ms]
       change: [-7.4763% -1.3648% +4.7496%] (p = 0.66 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [25.939 ms 26.754 ms 27.582 ms]
       change: [-2.3336% +1.7587% +6.1825%] (p = 0.43 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-true/same-seed: No change in performance detected.
       time:   [40.383 ms 42.219 ms 44.086 ms]
       change: [-11.376% -5.5546% +0.7201%] (p = 0.08 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [112.67 ms 113.15 ms 113.58 ms]
       thrpt:  [880.46 MiB/s 883.82 MiB/s 887.55 MiB/s]
change:
       time:   [-0.5587% +0.0118% +0.6028%] (p = 0.97 > 0.05)
       thrpt:  [-0.5992% -0.0118% +0.5619%]

Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) low severe
1 (1.00%) low mild

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [310.61 ms 314.23 ms 317.80 ms]
       thrpt:  [31.466 Kelem/s 31.824 Kelem/s 32.194 Kelem/s]
change:
       time:   [-1.0175% +0.5495% +2.2359%] (p = 0.50 > 0.05)
       thrpt:  [-2.1870% -0.5465% +1.0280%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [33.922 ms 34.112 ms 34.317 ms]
       thrpt:  [29.140  elem/s 29.315  elem/s 29.480  elem/s]
change:
       time:   [-0.4577% +0.3423% +1.1730%] (p = 0.42 > 0.05)
       thrpt:  [-1.1594% -0.3411% +0.4598%]

Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 109.4 ± 24.2 90.4 171.0 1.00
neqo msquic reno on 218.9 ± 10.1 206.3 236.4 1.00
neqo msquic reno 230.5 ± 12.1 207.1 241.8 1.00
neqo msquic cubic on 214.4 ± 13.4 204.0 252.4 1.00
neqo msquic cubic 221.3 ± 13.7 204.3 243.8 1.00
msquic neqo reno on 94.1 ± 20.8 81.9 177.1 1.00
msquic neqo reno 101.0 ± 21.1 83.0 179.5 1.00
msquic neqo cubic on 101.7 ± 26.8 82.4 190.8 1.00
msquic neqo cubic 123.7 ± 92.3 79.4 455.6 1.00
neqo neqo reno on 155.7 ± 35.2 125.4 230.4 1.00
neqo neqo reno 165.6 ± 61.0 130.0 384.5 1.00
neqo neqo cubic on 138.1 ± 18.9 121.2 204.5 1.00
neqo neqo cubic 153.4 ± 33.8 122.6 268.5 1.00

⬇️ Download logs

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.4.0 to 4.4.3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@5076954...b4b15b8)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/upload-artifact-4.4.3 branch from 13bd073 to 62a70d9 Compare October 14, 2024 09:53
@larseggert larseggert merged commit 4bd87eb into main Oct 14, 2024
6 checks passed
@larseggert larseggert deleted the dependabot/github_actions/actions/upload-artifact-4.4.3 branch October 14, 2024 09:56
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.39%. Comparing base (944c817) to head (946ff3c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2174   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files         112      112           
  Lines       36373    36373           
=======================================
  Hits        34697    34697           
  Misses       1676     1676           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant