Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Stop the PMTUD search at the interface MTU #2135

Merged
merged 35 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
d5191fb
feat: Stop the PMTUD search at the interface MTU
larseggert Sep 26, 2024
ead6c3c
Remove unused function, while I'm here.
larseggert Sep 26, 2024
3f83c05
Try and fix Firefox CI build
larseggert Sep 26, 2024
5f2e4b5
Use `stop` when we hit the iface MTU
larseggert Sep 27, 2024
5f03837
Log
larseggert Sep 30, 2024
4084085
Merge branch 'main' into feat-stop-pmtud-at-iface-mtu
larseggert Oct 8, 2024
cfb24b7
Try new PR for MTU
larseggert Oct 8, 2024
e485804
Remove stale comment
larseggert Oct 8, 2024
d35f7e4
Set policy
larseggert Oct 8, 2024
56a7a4b
Again
larseggert Oct 8, 2024
5ff1a7d
Again
larseggert Oct 8, 2024
be35124
Merge branch 'main' into feat-stop-pmtud-at-iface-mtu
larseggert Nov 22, 2024
1f18511
mtu 0.2.0
larseggert Nov 22, 2024
0b017e1
Merge branch 'main' into feat-stop-pmtud-at-iface-mtu
larseggert Nov 25, 2024
6ec0993
Merge branch 'main' into feat-stop-pmtud-at-iface-mtu
larseggert Nov 28, 2024
0822ea6
Add stats for interface and path MTU
larseggert Nov 28, 2024
8900893
Cargo.lock
larseggert Nov 28, 2024
8e8e81b
Not needed now that `[email protected]` is published
larseggert Nov 29, 2024
69fdf47
Merge branch 'main' into feat-stop-pmtud-at-iface-mtu
larseggert Nov 29, 2024
126812e
Bump `mtu` crate
larseggert Nov 29, 2024
ba79ce1
Trust windows-bindgen
larseggert Nov 29, 2024
20c1838
`windows-metadata`
larseggert Nov 29, 2024
988459c
[email protected]
larseggert Nov 29, 2024
ede84e3
[email protected]
larseggert Dec 2, 2024
3d043ce
Merge branch 'main' into feat-stop-pmtud-at-iface-mtu
larseggert Dec 12, 2024
1dc804b
Merge branch 'main' into feat-stop-pmtud-at-iface-mtu
larseggert Dec 17, 2024
74d08b7
Deps
larseggert Dec 17, 2024
89cfda5
Merge branch 'main' into feat-stop-pmtud-at-iface-mtu
larseggert Dec 17, 2024
524b4b1
Merge branch 'main' into feat-stop-pmtud-at-iface-mtu
larseggert Dec 18, 2024
03c4684
Update Cargo.lock
larseggert Dec 18, 2024
8004d36
Update Cargo.lock
larseggert Dec 18, 2024
639586e
Update neqo-transport/src/stats.rs
larseggert Dec 18, 2024
aa164db
Fixes
larseggert Dec 18, 2024
fdebdb1
Cargo.lock
larseggert Dec 18, 2024
2b85cfb
Address more code review comments
larseggert Dec 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/workflows/firefox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,16 +87,21 @@ jobs:

- name: Plumb in Neqo
run: |
# Get qlog version used by neqo
# Get qlog and mtu version used by neqo
cargo generate-lockfile
QLOG_VERSION=$(cargo pkgid qlog | cut -d@ -f2)
MTU_VERSION=$(cargo pkgid mtu | cut -d@ -f2)
rm Cargo.lock
cd mozilla-unified
{
echo '[[audits.qlog]]'
echo 'who = "CI"'
echo 'criteria = "safe-to-deploy"'
echo "version = \"$QLOG_VERSION\""
echo '[[audits.mtu]]'
echo 'who = "CI"'
echo 'criteria = "safe-to-deploy"'
echo "version = \"$MTU_VERSION\""
} >> supply-chain/audits.toml
sed -i'' -e "s/qlog =.*/qlog = \"$QLOG_VERSION\"/" netwerk/socket/neqo_glue/Cargo.toml
{
Expand All @@ -107,6 +112,18 @@ jobs:
echo 'neqo-qpack = { path = "../neqo-qpack" }'
echo 'neqo-crypto = { path = "../neqo-crypto" }'
} >> Cargo.toml
{
echo '[[trusted.windows-bindgen]]'
echo 'criteria = "safe-to-deploy"'
echo 'user-id = 64539 # Kenny Kerr (kennykerr)'
echo 'start = "2021-11-15"'
echo 'end = "2024-09-12"'
echo '[[trusted.windows-metadata]]'
echo 'criteria = "safe-to-deploy"'
echo 'user-id = 64539 # Kenny Kerr (kennykerr)'
echo 'start = "2021-11-15"'
echo 'end = "2024-09-12"'
} >> supply-chain/audits.toml
cargo update neqo-http3 neqo-transport neqo-common neqo-qpack neqo-crypto
./mach vendor rust --ignore-modified

Expand Down
82 changes: 82 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions neqo-transport/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ indexmap = { version = "2.2", default-features = false } # See https://github.co
log = { workspace = true }
neqo-common = { path = "../neqo-common" }
neqo-crypto = { path = "../neqo-crypto" }
mtu = { version = "0.2.3", default-features = false } # neqo is only user currently, can bump freely
qlog = { workspace = true }
smallvec = { version = "1.13", default-features = false }
static_assertions = { workspace = true }
Expand All @@ -41,6 +42,7 @@ build-fuzzing-corpus = [
]
disable-encryption = ["neqo-crypto/disable-encryption"]
draft-29 = []
gecko = ["mtu/gecko"]

[lib]
# See https://github.com/bheisler/criterion.rs/blob/master/book/src/faq.md#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options
Expand Down
Loading
Loading