Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Speed up NSS build with sccache #2091

Merged
merged 16 commits into from
Sep 17, 2024
Merged

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert commented Sep 6, 2024

Seems to help a bit.

Copy link

github-actions bot commented Sep 6, 2024

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

Copy link

github-actions bot commented Sep 6, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (5410bd0) to head (ec32134).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2091   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files         112      112           
  Lines       36325    36319    -6     
=======================================
- Hits        34636    34631    -5     
+ Misses       1689     1688    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larseggert larseggert marked this pull request as ready for review September 6, 2024 13:45
Copy link

github-actions bot commented Sep 9, 2024

Benchmark results

Performance differences relative to 75372c2.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.088 ns 99.443 ns 99.811 ns]
       change: [-0.3787% +0.1879% +0.7653%] (p = 0.56 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
11 (11.00%) high mild
4 (4.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [116.77 ns 117.13 ns 117.51 ns]
       change: [-0.4730% +0.0417% +0.5505%] (p = 0.88 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
2 (2.00%) low mild
1 (1.00%) high mild
13 (13.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.24 ns 116.68 ns 117.21 ns]
       change: [-0.6196% -0.1294% +0.2739%] (p = 0.59 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
1 (1.00%) low severe
3 (3.00%) low mild
2 (2.00%) high mild
5 (5.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.306 ns 97.520 ns 97.776 ns]
       change: [-1.2463% -0.4491% +0.3468%] (p = 0.28 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
4 (4.00%) high mild
6 (6.00%) high severe

RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [111.00 ms 111.12 ms 111.33 ms]
       change: [-0.1806% -0.0483% +0.1792%] (p = 0.69 > 0.05)

Found 20 outliers among 100 measurements (20.00%)
3 (3.00%) low mild
12 (12.00%) high mild
5 (5.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.382 ms 27.406 ms 28.442 ms]
       change: [-7.7654% -2.6336% +2.8598%] (p = 0.33 > 0.05)

Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low mild
2 (2.00%) high mild

transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [34.506 ms 36.192 ms 37.868 ms]
       change: [-8.7642% -3.0132% +3.3792%] (p = 0.35 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [31.346 ms 32.077 ms 32.799 ms]
       change: [-5.1629% -2.0279% +1.4406%] (p = 0.24 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [39.834 ms 42.406 ms 45.010 ms]
       change: [-9.3749% -0.6656% +8.7067%] (p = 0.89 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [113.02 ms 113.45 ms 113.89 ms]
       thrpt:  [878.01 MiB/s 881.42 MiB/s 884.82 MiB/s]
change:
       time:   [-6.5936% -1.8380% +0.9331%] (p = 0.64 > 0.05)
       thrpt:  [-0.9245% +1.8724% +7.0590%]

Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low severe
1 (1.00%) low mild
1 (1.00%) high severe

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [314.50 ms 318.36 ms 322.20 ms]
       thrpt:  [31.036 Kelem/s 31.411 Kelem/s 31.797 Kelem/s]
change:
       time:   [-1.2258% +0.4540% +2.2000%] (p = 0.59 > 0.05)
       thrpt:  [-2.1526% -0.4520% +1.2410%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [33.648 ms 33.864 ms 34.095 ms]
       thrpt:  [29.329  elem/s 29.530  elem/s 29.719  elem/s]
change:
       time:   [-1.2229% -0.3984% +0.4736%] (p = 0.36 > 0.05)
       thrpt:  [-0.4714% +0.4000% +1.2380%]

Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high mild

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 141.2 ± 74.6 90.8 324.0 1.00
neqo msquic reno on 231.1 ± 59.7 199.7 416.0 1.00
neqo msquic reno 217.2 ± 12.6 203.2 239.0 1.00
neqo msquic cubic on 249.2 ± 68.8 205.0 429.2 1.00
neqo msquic cubic 215.7 ± 11.8 203.2 239.2 1.00
msquic neqo reno on 150.4 ± 125.9 82.4 562.9 1.00
msquic neqo reno 126.2 ± 74.5 81.4 327.1 1.00
msquic neqo cubic on 157.6 ± 135.0 81.1 570.3 1.00
msquic neqo cubic 113.2 ± 63.9 81.0 360.5 1.00
neqo neqo reno on 149.9 ± 39.8 124.0 301.8 1.00
neqo neqo reno 155.7 ± 21.1 123.3 192.6 1.00
neqo neqo cubic on 314.9 ± 154.1 137.6 592.7 1.00
neqo neqo cubic 203.4 ± 136.3 125.2 688.4 1.00

⬇️ Download logs

@larseggert larseggert merged commit cca3db2 into mozilla:main Sep 17, 2024
58 checks passed
@larseggert larseggert deleted the ci-nss-sccache branch September 17, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant