ci: Try to use NSS package on Linux #1900
Conversation
Which is still being rolled out, but has a bunch of advantages for us.
|
Runners are ready, but |
|
@martinthomson any idea what could be causing the two CHACHA20 tests to fail? https://github.com/mozilla/neqo/actions/runs/9562522589/job/26359069786?pr=1900#step:11:317 |
|
No. No idea at all. That failure is pretty troubling. If that were to happen in practice, it would mean a complete failure to encrypt, without hitting the error path. Looking at the function that fails, we have a completely fresh The failure has to be in the |
|
@martinthomson so this is not an I don't understand why I cant reproduce this locally in either a VM or in docker. |
larseggert
changed the title
ubuntu-24.04
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1900 +/- ##
==========================================
- Coverage 94.97% 94.97% -0.01%
==========================================
Files 112 112
Lines 36504 36504
==========================================
- Hits 34670 34668 -2
- Misses 1834 1836 +2 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 80c7969. coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [191.73 ns 192.23 ns 192.75 ns]
change: [-1.4693% -1.0117% -0.5614%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [233.76 ns 234.32 ns 234.94 ns]
change: [-1.0631% -0.6036% -0.1008%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [234.51 ns 237.92 ns 244.24 ns]
change: [-0.7551% +0.7019% +3.0849%] (p = 0.66 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [216.96 ns 217.13 ns 217.33 ns]
change: [-0.4507% +0.1516% +0.6982%] (p = 0.65 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [119.45 ms 119.61 ms 119.85 ms]
change: [-1.0366% -0.7954% -0.5526%] (p = 0.00 < 0.05)
transfer/Run multiple transfers with varying seeds: No change in performance detected. time: [56.196 ms 59.348 ms 62.512 ms]
thrpt: [63.987 MiB/s 67.399 MiB/s 71.179 MiB/s]
change:
time: [-0.5491% +7.2542% +15.616%] (p = 0.07 > 0.05)
thrpt: [-13.507% -6.7636% +0.5522%]
transfer/Run multiple transfers with the same seed: No change in performance detected. time: [61.263 ms 68.012 ms 74.651 ms]
thrpt: [53.583 MiB/s 58.813 MiB/s 65.293 MiB/s]
change:
time: [-16.242% -4.0743% +10.491%] (p = 0.55 > 0.05)
thrpt: [-9.4947% +4.2474% +19.391%]
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [272.45 ms 279.05 ms 285.40 ms]
thrpt: [350.39 MiB/s 358.36 MiB/s 367.03 MiB/s]
change:
time: [-5.2245% -2.5643% -0.0756%] (p = 0.09 > 0.05)
thrpt: [+0.0756% +2.6318% +5.5125%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [443.69 ms 446.97 ms 450.28 ms]
thrpt: [22.208 Kelem/s 22.373 Kelem/s 22.538 Kelem/s]
change:
time: [-0.0523% +1.0470% +2.1343%] (p = 0.06 > 0.05)
thrpt: [-2.0897% -1.0362% +0.0523%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [68.348 ms 68.710 ms 69.121 ms]
thrpt: [14.467 elem/s 14.554 elem/s 14.631 elem/s]
change:
time: [-1.0226% -0.2098% +0.5982%] (p = 0.62 > 0.05)
thrpt: [-0.5946% +0.2102% +1.0332%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
This should speed up CI.