Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use MIN_INITIAL_PACKET_SIZE instead of literal 1200 #1895

Merged
merged 1 commit into from
May 13, 2024
Merged

chore: Use MIN_INITIAL_PACKET_SIZE instead of literal 1200 #1895

merged 1 commit into from
May 13, 2024

Conversation

larseggert
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

Failed Interop Tests

QUIC Interop Runner, client vs. server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

@codecov Codecov
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.20%. Comparing base (3015218) to head (beb1c2d).

Files Patch % Lines
neqo-transport/src/tparams.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1895   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         111      111           
  Lines       36027    36028    +1     
=======================================
+ Hits        33579    33580    +1     
  Misses       2448     2448

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Benchmark results

Performance differences relative to 3015218.

  • drain a timer quickly time: [319.27 ns 326.27 ns 332.84 ns]
    change: [+2.1180% +4.1448% +6.1334%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 1+1 entries
    time: [194.87 ns 195.27 ns 195.72 ns]
    change: [+0.2384% +0.7057% +1.2693%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • coalesce_acked_from_zero 3+1 entries
    time: [237.45 ns 238.10 ns 238.73 ns]
    change: [-1.6690% -1.2327% -0.7340%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • coalesce_acked_from_zero 10+1 entries
    time: [237.07 ns 237.68 ns 238.46 ns]
    change: [-2.1043% -1.3798% -0.7122%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • coalesce_acked_from_zero 1000+1 entries
    time: [218.29 ns 226.39 ns 244.40 ns]
    change: [-0.3824% +1.7817% +6.6591%] (p = 0.40 > 0.05)
    No change in performance detected.

  • RxStreamOrderer::inbound_frame()
    time: [119.95 ms 120.00 ms 120.06 ms]
    change: [+1.0481% +1.1291% +1.2110%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • transfer/Run multiple transfers with varying seeds
    time: [120.86 ms 121.15 ms 121.44 ms]
    thrpt: [32.939 MiB/s 33.018 MiB/s 33.097 MiB/s]
    change:
    time: [+0.2904% +0.6373% +0.9771%] (p = 0.00 < 0.05)
    thrpt: [-0.9677% -0.6333% -0.2895%]
    Change within noise threshold.

  • transfer/Run multiple transfers with the same seed
    time: [120.92 ms 121.18 ms 121.46 ms]
    thrpt: [32.933 MiB/s 33.008 MiB/s 33.081 MiB/s]
    change:
    time: [+0.2614% +0.5737% +0.8999%] (p = 0.00 < 0.05)
    thrpt: [-0.8918% -0.5704% -0.2607%]
    Change within noise threshold.

  • 1-conn/1-100mb-resp (aka. Download)/client
    time: [1.1467 s 1.1509 s 1.1557 s]
    thrpt: [86.527 MiB/s 86.886 MiB/s 87.206 MiB/s]
    change:
    time: [+0.4953% +0.9694% +1.4900%] (p = 0.00 < 0.05)
    thrpt: [-1.4682% -0.9601% -0.4928%]
    Change within noise threshold.

  • 1-conn/10_000-parallel-1b-resp (aka. RPS)/client
    time: [428.68 ms 430.82 ms 432.99 ms]
    thrpt: [23.095 Kelem/s 23.211 Kelem/s 23.327 Kelem/s]
    change:
    time: [-0.5555% +0.1291% +0.8129%] (p = 0.72 > 0.05)
    thrpt: [-0.8063% -0.1290% +0.5586%]
    No change in performance detected.

  • 1-conn/1-1b-resp (aka. HPS)/client
    time: [49.596 ms 49.845 ms 50.121 ms]
    thrpt: [19.952 elem/s 20.062 elem/s 20.163 elem/s]
    change:
    time: [-0.5082% +0.0951% +0.6163%] (p = 0.76 > 0.05)
    thrpt: [-0.6125% -0.0950% +0.5108%]
    No change in performance detected.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 657.6 ± 177.1 437.1 946.1 1.00
neqo msquic reno on 982.6 ± 137.6 817.7 1171.0 1.00
neqo msquic reno 981.7 ± 177.4 809.8 1286.8 1.00
neqo msquic cubic on 1051.1 ± 273.6 790.0 1476.3 1.00
neqo msquic cubic 978.7 ± 200.1 789.7 1285.2 1.00
msquic neqo reno on 5440.0 ± 166.7 5122.4 5693.1 1.00
msquic neqo reno 5352.5 ± 178.5 5003.1 5582.4 1.00
msquic neqo cubic on 5192.3 ± 196.0 4827.5 5516.5 1.00
msquic neqo cubic 5136.2 ± 274.6 4714.8 5605.1 1.00
neqo neqo reno on 4831.8 ± 295.2 4364.1 5224.1 1.00
neqo neqo reno 3974.4 ± 434.3 2987.6 4540.9 1.00
neqo neqo cubic on 4936.6 ± 193.2 4636.9 5288.9 1.00
neqo neqo cubic 4840.0 ± 346.0 4082.0 5441.8 1.00

⬇️ Download logs

@github-actions GitHub Actions
Copy link

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

@larseggert larseggert enabled auto-merge May 10, 2024 15:35
@larseggert larseggert added this pull request to the merge queue May 13, 2024
Merged via the queue into mozilla:main with commit d7f33e2 May 13, 2024
55 of 56 checks passed
@larseggert larseggert deleted the chore-1200 branch May 13, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KershawChang KershawChang KershawChang approved these changes

@martinthomson martinthomson Awaiting requested review from martinthomson martinthomson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larseggert @KershawChang