ci: Only build Fx for PRs

[larseggert]

And not when landing a PR in main. Can manually make it build for main via workflow_dispatch.

[github-actions]

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

• Linux: Debug Release
• macOS: Debug Release
• Windows: Debug Release

[github-actions]

Failed Interop Tests

QUIC Interop Runner, client vs. server

• aioquic vs. neqo-latest: R A
• go-x-net vs. neqo-latest: A
• kwik vs. neqo-latest: A
• lsquic vs. neqo-latest: R A
• msquic vs. neqo-latest: Z A
• mvfst vs. neqo-latest: Z 3 A L1 C1
• neqo vs. neqo-latest: A
• neqo-latest vs. aioquic: Z C1
• neqo-latest vs. haproxy: Z
• neqo-latest vs. kwik: C1
• neqo-latest vs. msquic: Z A L1 C1
• neqo-latest vs. mvfst: DC B U A L1 L2 C1 C2
• neqo-latest vs. neqo: A L1
• neqo-latest vs. neqo-latest: A
• neqo-latest vs. ngtcp2: Z
• neqo-latest vs. quic-go: Z C1
• neqo-latest vs. quiche: L1 C1
• neqo-latest vs. quinn: E A
• neqo-latest vs. s2n-quic: R
• neqo-latest vs. xquic: Z A
• ngtcp2 vs. neqo-latest: A
• picoquic vs. neqo-latest: R A
• quic-go vs. neqo-latest: A
• quiche vs. neqo-latest: R 3 A
• quinn vs. neqo-latest: R Z E A
• s2n-quic vs. neqo-latest: A
• xquic vs. neqo-latest: M A C1

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

• aioquic vs. neqo-latest: H DC LR C20 M S Z 3 B L1 L2 C1 C2 6
• chrome vs. neqo-latest: 3
• go-x-net vs. neqo-latest: H DC LR M B U L2 C2 6
• kwik vs. neqo-latest: H DC LR C20 M S R Z 3 B U L1 L2 C1 C2 6 V2
• lsquic vs. neqo-latest: H DC LR M S 3 B E L1 L2 C1 C2 6 V2
• msquic vs. neqo-latest: H DC LR C20 M S R B U L1 L2 C1 C2 6 V2
• mvfst vs. neqo-latest: H DC LR M B L2 C2 6
• neqo vs. neqo-latest: H DC LR C20 M S R Z 3 B U E L1 L2 C1 C2 6 V2
• neqo-latest vs. aioquic: H DC LR C20 M S R 3 B U A L1 L2 C2 6
• neqo-latest vs. go-x-net: H DC LR M B U A L2 C2 6
• neqo-latest vs. haproxy: H DC LR C20 M S R 3 B U A L1 L2 C1 C2 6 V2
• neqo-latest vs. kwik: H DC LR C20 M S R Z 3 B U A L1 L2 C2 6 V2
• neqo-latest vs. lsquic: H DC LR C20 M S R Z 3 B U E A L1 L2 C1 C2 6 V2
• neqo-latest vs. msquic: H DC LR C20 M S R B U L2 C2 6 V2
• neqo-latest vs. mvfst: H LR M R Z 3 6
• neqo-latest vs. neqo: H DC LR C20 M S R Z 3 B U E L2 C1 C2 6 V2
• neqo-latest vs. neqo-latest: H DC LR C20 M S R Z 3 B U E L1 L2 C1 C2 6 V2
• neqo-latest vs. nginx: H DC LR C20 M S R Z 3 B U A L1 L2 C1 C2 6
• neqo-latest vs. ngtcp2: H DC LR C20 M S R 3 B U E A L1 L2 C1 C2 6 V2
• neqo-latest vs. picoquic: H DC LR C20 M S R Z 3 B U E A L1 L2 C1 C2 6 V2
• neqo-latest vs. quic-go: H DC LR C20 M S R 3 B U A L1 L2 C2 6
• neqo-latest vs. quiche: H DC LR C20 M S R Z 3 B U A L2 C2 6
• neqo-latest vs. quinn: H DC LR C20 M S R Z 3 B U L2 C2 6
• neqo-latest vs. s2n-quic: H DC LR C20 M S 3 B U E A L1 L2 C1 C2 6
• neqo-latest vs. xquic: H DC LR C20 M R 3 B U L1 L2 C1 C2 6
• ngtcp2 vs. neqo-latest: H DC LR C20 M S R Z 3 B U E L1 L2 C1 C2 6 V2
• picoquic vs. neqo-latest: H DC LR C20 M S Z 3 B U E L1 L2 C1 C2 6 V2
• quic-go vs. neqo-latest: H DC LR C20 M S R Z 3 B U L1 L2 C1 C2 6
• quiche vs. neqo-latest: H DC LR M S Z B L1 L2 C1 C2 6
• quinn vs. neqo-latest: H DC LR C20 M S 3 B U L2 C2 6
• s2n-quic vs. neqo-latest: H DC LR M S R 3 B E L1 L2 C1 C2 6
• xquic vs. neqo-latest: H DC LR C20 S R Z 3 B U L1 L2 C2 6

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

• aioquic vs. neqo-latest: U E V2
• chrome vs. neqo-latest: H DC LR C20 M S R Z B U E A L1 L2 C1 C2 6 V2
• go-x-net vs. neqo-latest: C20 S R Z 3 E L1 C1 V2
• kwik vs. neqo-latest: E
• lsquic vs. neqo-latest: C20 Z U
• msquic vs. neqo-latest: 3 E
• mvfst vs. neqo-latest: C20 S R U E V2
• neqo-latest vs. aioquic: E V2
• neqo-latest vs. go-x-net: C20 S R Z 3 E L1 C1 V2
• neqo-latest vs. haproxy: E
• neqo-latest vs. kwik: E
• neqo-latest vs. msquic: 3 E
• neqo-latest vs. mvfst: C20 S E V2
• neqo-latest vs. nginx: E V2
• neqo-latest vs. quic-go: E V2
• neqo-latest vs. quiche: E V2
• neqo-latest vs. quinn: L1 C1 V2
• neqo-latest vs. s2n-quic: Z V2
• neqo-latest vs. xquic: S E V2
• quic-go vs. neqo-latest: E V2
• quiche vs. neqo-latest: C20 U E V2
• quinn vs. neqo-latest: L1 C1 V2
• s2n-quic vs. neqo-latest: C20 Z U V2
• xquic vs. neqo-latest: E V2

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.20%. Comparing base (beffcc6) to head (312cb38).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1890   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         111      111           
  Lines       36027    36027           
=======================================
  Hits        33580    33580           
  Misses       2447     2447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark results

Performance differences relative to beffcc6.

• drain a timer quickly time: [305.60 ns 314.09 ns 322.20 ns]
  change: [-2.9730% -0.8892% +1.2223%] (p = 0.43 > 0.05)
  No change in performance detected.

• coalesce_acked_from_zero 1+1 entries
  time: [194.31 ns 194.75 ns 195.20 ns]
  change: [-2.2443% -1.0883% -0.3226%] (p = 0.02 < 0.05)
  Change within noise threshold.

• coalesce_acked_from_zero 3+1 entries
  time: [239.36 ns 239.86 ns 240.42 ns]
  change: [+0.5516% +0.9339% +1.3230%] (p = 0.00 < 0.05)
  Change within noise threshold.

• coalesce_acked_from_zero 10+1 entries
  time: [239.61 ns 240.58 ns 241.71 ns]
  change: [+0.8809% +1.6990% +2.6477%] (p = 0.00 < 0.05)
  Change within noise threshold.

• coalesce_acked_from_zero 1000+1 entries
  time: [219.26 ns 226.54 ns 242.97 ns]
  change: [+0.3746% +2.8337% +8.6072%] (p = 0.13 > 0.05)
  No change in performance detected.

• RxStreamOrderer::inbound_frame()
  time: [118.73 ms 118.78 ms 118.84 ms]
  change: [-0.3104% -0.2329% -0.1600%] (p = 0.00 < 0.05)
  Change within noise threshold.

• transfer/Run multiple transfers with varying seeds
  time: [120.32 ms 120.62 ms 120.92 ms]
  thrpt: [33.079 MiB/s 33.161 MiB/s 33.244 MiB/s]
  change:
  time: [-0.0493% +0.2749% +0.5757%] (p = 0.10 > 0.05)
  thrpt: [-0.5724% -0.2742% +0.0493%]
  No change in performance detected.

• transfer/Run multiple transfers with the same seed
  time: [120.19 ms 120.44 ms 120.70 ms]
  thrpt: [33.141 MiB/s 33.212 MiB/s 33.282 MiB/s]
  change:
  time: [-0.1569% +0.1264% +0.4020%] (p = 0.39 > 0.05)
  thrpt: [-0.4004% -0.1263% +0.1571%]
  No change in performance detected.

• 1-conn/1-100mb-resp (aka. Download)/client
  time: [1.1208 s 1.1254 s 1.1302 s]
  thrpt: [88.480 MiB/s 88.856 MiB/s 89.223 MiB/s]
  change:
  time: [-0.6867% +0.5536% +1.6555%] (p = 0.40 > 0.05)
  thrpt: [-1.6286% -0.5505% +0.6914%]
  No change in performance detected.

• 1-conn/10_000-parallel-1b-resp (aka. RPS)/client
  time: [429.04 ms 431.16 ms 433.29 ms]
  thrpt: [23.079 Kelem/s 23.193 Kelem/s 23.308 Kelem/s]
  change:
  time: [+0.2055% +0.8998% +1.5346%] (p = 0.01 < 0.05)
  thrpt: [-1.5114% -0.8918% -0.2051%]
  Change within noise threshold.

• 1-conn/1-1b-resp (aka. HPS)/client
  time: [49.949 ms 50.146 ms 50.386 ms]
  thrpt: [19.847 elem/s 19.942 elem/s 20.020 elem/s]
  change:
  time: [-0.8731% +0.1643% +0.9638%] (p = 0.77 > 0.05)
  thrpt: [-0.9546% -0.1640% +0.8808%]
  No change in performance detected.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client	Server	CC	Pacing	Mean [ms]	Min [ms]	Max [ms]	Relative
msquic	msquic			653.4 ± 319.6	359.3	1301.3	1.00
neqo	msquic	reno	on	957.5 ± 215.7	779.6	1338.2	1.00
neqo	msquic	reno		958.1 ± 133.5	767.2	1149.8	1.00
neqo	msquic	cubic	on	874.7 ± 134.9	753.8	1215.2	1.00
neqo	msquic	cubic		869.4 ± 143.9	759.7	1163.2	1.00
msquic	neqo	reno	on	5520.4 ± 298.3	5094.4	6003.5	1.00
msquic	neqo	reno		5490.8 ± 285.9	5120.5	6047.1	1.00
msquic	neqo	cubic	on	5182.8 ± 221.5	4848.5	5548.0	1.00
msquic	neqo	cubic		5174.4 ± 299.2	4856.2	5857.0	1.00
neqo	neqo	reno	on	4091.5 ± 314.9	3499.4	4420.7	1.00
neqo	neqo	reno		4302.9 ± 127.0	4035.6	4464.0	1.00
neqo	neqo	cubic	on	4973.6 ± 160.4	4700.4	5314.2	1.00
neqo	neqo	cubic		4950.2 ± 250.8	4565.0	5508.5	1.00

⬇️ Download logs