Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Need to run QNS on push to main #1870

Merged
merged 1 commit into from
May 2, 2024

Conversation

larseggert
Copy link
Collaborator

So we get baseline data

So we get baseline data
Copy link

github-actions bot commented May 2, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

@larseggert larseggert merged commit 0b498cd into mozilla:main May 2, 2024
47 checks passed
@larseggert larseggert deleted the ci-qns-on-push branch May 2, 2024 14:14
Copy link

github-actions bot commented May 2, 2024

Benchmark results

Performance differences relative to 8c4411a.

  • drain a timer quickly time: [311.87 ns 319.96 ns 327.43 ns]
    change: [-2.1508% +0.0365% +2.4311%] (p = 0.97 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1+1 entries
    time: [198.13 ns 198.58 ns 199.07 ns]
    change: [+0.9224% +1.7078% +2.2743%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • coalesce_acked_from_zero 3+1 entries
    time: [241.26 ns 241.94 ns 242.66 ns]
    change: [+1.3124% +1.7387% +2.1754%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 10+1 entries
    time: [239.33 ns 239.94 ns 240.70 ns]
    change: [+0.7394% +1.2552% +1.6914%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • coalesce_acked_from_zero 1000+1 entries
    time: [219.92 ns 220.15 ns 220.39 ns]
    change: [+0.4898% +1.1926% +2.0280%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • RxStreamOrderer::inbound_frame()
    time: [118.95 ms 119.00 ms 119.06 ms]
    change: [-0.4866% -0.4081% -0.3299%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • transfer/Run multiple transfers with varying seeds
    time: [118.39 ms 118.62 ms 118.86 ms]
    thrpt: [33.654 MiB/s 33.720 MiB/s 33.788 MiB/s]
    change:
    time: [-0.6585% -0.3766% -0.0866%] (p = 0.01 < 0.05)
    thrpt: [+0.0867% +0.3780% +0.6628%]
    Change within noise threshold.

  • transfer/Run multiple transfers with the same seed
    time: [118.28 ms 118.50 ms 118.72 ms]
    thrpt: [33.692 MiB/s 33.756 MiB/s 33.819 MiB/s]
    change:
    time: [-0.5428% -0.2821% -0.0024%] (p = 0.04 < 0.05)
    thrpt: [+0.0024% +0.2829% +0.5458%]
    Change within noise threshold.

  • 1-conn/1-100mb-resp (aka. Download)/client
    time: [1.0927 s 1.1015 s 1.1108 s]
    thrpt: [90.026 MiB/s 90.783 MiB/s 91.513 MiB/s]
    change:
    time: [-4.1792% -2.8375% -1.6521%] (p = 0.00 < 0.05)
    thrpt: [+1.6798% +2.9204% +4.3615%]
    💚 Performance has improved.

  • 1-conn/10_000-parallel-1b-resp (aka. RPS)/client
    time: [427.73 ms 430.32 ms 432.90 ms]
    thrpt: [23.100 Kelem/s 23.239 Kelem/s 23.379 Kelem/s]
    change:
    time: [-1.3270% -0.5466% +0.1798%] (p = 0.18 > 0.05)
    thrpt: [-0.1795% +0.5496% +1.3448%]
    No change in performance detected.

  • 1-conn/1-1b-resp (aka. HPS)/client
    time: [48.563 ms 48.853 ms 49.147 ms]
    thrpt: [20.347 elem/s 20.470 elem/s 20.592 elem/s]
    change:
    time: [-1.1003% +0.4529% +1.9453%] (p = 0.58 > 0.05)
    thrpt: [-1.9082% -0.4509% +1.1126%]
    No change in performance detected.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 749.1 ± 234.9 443.9 1059.1 1.00
neqo msquic reno on 1065.6 ± 176.1 763.4 1384.2 1.00
neqo msquic reno 936.6 ± 240.3 739.9 1438.2 1.00
neqo msquic cubic on 963.3 ± 286.4 753.2 1588.7 1.00
neqo msquic cubic 908.4 ± 238.7 760.9 1426.9 1.00
msquic neqo reno on 4504.6 ± 268.9 4190.2 5105.8 1.00
msquic neqo reno 4320.7 ± 184.8 3975.6 4619.8 1.00
msquic neqo cubic on 4420.0 ± 145.7 4234.7 4664.8 1.00
msquic neqo cubic 4407.7 ± 213.2 4139.3 4710.9 1.00
neqo neqo reno on 3716.4 ± 433.7 3145.0 4623.5 1.00
neqo neqo reno 3762.9 ± 154.3 3489.5 3957.1 1.00
neqo neqo cubic on 4323.3 ± 338.4 3631.7 4895.9 1.00
neqo neqo cubic 4038.7 ± 438.6 2988.6 4481.3 1.00

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant