Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable ossf/scorecard-action until it's allowlisted #1809

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

larseggert
Copy link
Collaborator

No description provided.

@larseggert larseggert merged commit 98f7b26 into mozilla:main Apr 9, 2024
11 of 13 checks passed
@larseggert larseggert deleted the ci-disable-scorecard branch April 9, 2024 13:37
Copy link

github-actions bot commented Apr 9, 2024

Benchmark results

Performance differences relative to 7ff76c7.

  • drain a timer quickly time: [356.97 ns 365.02 ns 372.64 ns]
    change: [-12.522% -6.5808% -2.5350%] (p = 0.01 < 0.05)
    💚 Performance has improved.

  • coalesce_acked_from_zero 1+1 entries
    time: [194.24 ns 194.74 ns 195.25 ns]
    change: [-0.6973% -0.2429% +0.1601%] (p = 0.27 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 3+1 entries
    time: [238.48 ns 239.14 ns 239.87 ns]
    change: [-0.1267% +0.3331% +0.7995%] (p = 0.18 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 10+1 entries
    time: [237.15 ns 237.79 ns 238.59 ns]
    change: [-0.2999% +0.3524% +1.1869%] (p = 0.35 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1000+1 entries
    time: [219.45 ns 228.56 ns 248.38 ns]
    change: [-0.6348% +1.6973% +5.5288%] (p = 0.47 > 0.05)
    No change in performance detected.

  • RxStreamOrderer::inbound_frame()
    time: [118.02 ms 118.20 ms 118.43 ms]
    change: [-0.3684% -0.1699% +0.0732%] (p = 0.13 > 0.05)
    No change in performance detected.

  • transfer/Run multiple transfers with varying seeds
    time: [119.48 ms 119.77 ms 120.07 ms]
    thrpt: [33.315 MiB/s 33.397 MiB/s 33.479 MiB/s]
    change:
    time: [-0.7288% -0.3791% -0.0245%] (p = 0.03 < 0.05)
    thrpt: [+0.0245% +0.3806% +0.7341%]
    Change within noise threshold.

  • transfer/Run multiple transfers with the same seed
    time: [120.38 ms 120.55 ms 120.73 ms]
    thrpt: [33.132 MiB/s 33.181 MiB/s 33.228 MiB/s]
    change:
    time: [-0.4386% -0.2146% -0.0038%] (p = 0.05 > 0.05)
    thrpt: [+0.0038% +0.2151% +0.4406%]
    No change in performance detected.

  • 1-conn/1-100mb-resp (aka. Download)/client
    time: [1.1102 s 1.1318 s 1.1582 s]
    thrpt: [86.337 MiB/s 88.353 MiB/s 90.073 MiB/s]
    change:
    time: [-0.9544% +1.2985% +3.7731%] (p = 0.35 > 0.05)
    thrpt: [-3.6359% -1.2819% +0.9636%]
    No change in performance detected.

  • 1-conn/10_000-parallel-1b-resp (aka. RPS)/client
    time: [428.36 ms 430.63 ms 432.96 ms]
    thrpt: [23.097 Kelem/s 23.222 Kelem/s 23.345 Kelem/s]
    change:
    time: [-0.9473% -0.2008% +0.5437%] (p = 0.60 > 0.05)
    thrpt: [-0.5408% +0.2012% +0.9564%]
    No change in performance detected.

  • 1-conn/1-1b-resp (aka. HPS)/client
    time: [51.054 ms 51.433 ms 51.837 ms]
    thrpt: [19.291 elem/s 19.443 elem/s 19.587 elem/s]
    change:
    time: [-0.6682% +0.4549% +1.5790%] (p = 0.42 > 0.05)
    thrpt: [-1.5545% -0.4529% +0.6727%]
    No change in performance detected.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 724.7 ± 347.6 370.3 1459.0 1.00
neqo msquic reno on 914.2 ± 237.6 762.2 1474.9 1.00
neqo msquic reno 941.8 ± 257.5 758.6 1490.0 1.00
neqo msquic cubic on 997.3 ± 243.0 733.0 1363.3 1.00
neqo msquic cubic 889.4 ± 161.4 761.7 1233.5 1.00
msquic neqo reno on 4387.9 ± 213.8 4139.4 4832.4 1.00
msquic neqo reno 4456.4 ± 303.7 4150.8 5107.2 1.00
msquic neqo cubic on 4518.3 ± 171.4 4185.7 4695.2 1.00
msquic neqo cubic 4454.7 ± 189.9 4155.4 4809.4 1.00
neqo neqo reno on 3555.7 ± 335.3 3242.9 4289.0 1.00
neqo neqo reno 3465.7 ± 191.4 3214.3 3818.2 1.00
neqo neqo cubic on 4328.4 ± 248.9 4062.8 4906.5 1.00
neqo neqo cubic 4269.7 ± 200.8 3970.7 4641.7 1.00

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant