-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add my test.sh
script
#1802
Conversation
Because I keep blowing it away when I `git clean`...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1802 +/- ##
=======================================
Coverage 93.13% 93.13%
=======================================
Files 117 117
Lines 36363 36363
=======================================
Hits 33865 33865
Misses 2498 2498 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 32a2a59.
Client/server transfer resultsTransfer of 134217728 bytes over loopback.
|
tshark -r $tmp/test.pcap -o tls.keylog_file:$tmp/test.tlskey" \; \ | ||
set remain-on-exit on | ||
|
||
# rm -rf "$tmp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably use trap 'rm -rf "$tmp"' EXIT
instead. Especially with set -e
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! #1810
Because I keep blowing it away when I
git clean
...