Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix shell script bugs in nss/action.yml #1778

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

larseggert
Copy link
Collaborator

No description provided.

Copy link

Benchmark results

Performance differences relative to efc4813.

  • drain a timer quickly time: [392.12 ns 399.68 ns 406.72 ns]
    change: [-1.5662% +0.0452% +1.5759%] (p = 0.95 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1+1 entries
    time: [197.72 ns 198.21 ns 198.72 ns]
    change: [-0.2173% +0.1007% +0.4289%] (p = 0.55 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 3+1 entries
    time: [236.41 ns 236.89 ns 237.45 ns]
    change: [-0.3314% +0.0184% +0.3635%] (p = 0.92 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 10+1 entries
    time: [236.33 ns 237.06 ns 237.93 ns]
    change: [-0.8405% -0.1884% +0.3700%] (p = 0.58 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1000+1 entries
    time: [214.37 ns 214.61 ns 214.86 ns]
    change: [-1.6693% -1.0432% -0.4414%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • RxStreamOrderer::inbound_frame()
    time: [119.50 ms 119.57 ms 119.63 ms]
    change: [-0.9435% -0.8612% -0.7763%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • transfer/Run multiple transfers with varying seeds
    time: [119.09 ms 119.36 ms 119.62 ms]
    thrpt: [33.440 MiB/s 33.512 MiB/s 33.587 MiB/s]
    change:
    time: [-0.3654% -0.0189% +0.3409%] (p = 0.91 > 0.05)
    thrpt: [-0.3397% +0.0189% +0.3668%]
    No change in performance detected.

  • transfer/Run multiple transfers with the same seed
    time: [120.05 ms 120.20 ms 120.36 ms]
    thrpt: [33.234 MiB/s 33.277 MiB/s 33.318 MiB/s]
    change:
    time: [+0.2636% +0.4489% +0.6429%] (p = 0.00 < 0.05)
    thrpt: [-0.6388% -0.4469% -0.2629%]
    Change within noise threshold.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 660.3 ± 243.4 390.2 1185.8 1.00
neqo msquic reno on 2172.0 ± 322.6 1903.7 2740.3 1.00
neqo msquic reno 2033.3 ± 186.9 1871.2 2451.0 1.00
neqo msquic cubic on 1991.8 ± 179.8 1856.2 2482.0 1.00
neqo msquic cubic 1944.8 ± 149.0 1746.6 2328.9 1.00
msquic neqo reno on 4535.5 ± 277.4 4212.9 5039.5 1.00
msquic neqo reno 4457.9 ± 316.3 4109.8 5160.9 1.00
msquic neqo cubic on 4474.7 ± 151.7 4257.3 4672.5 1.00
msquic neqo cubic 4624.9 ± 297.0 4241.0 5238.4 1.00
neqo neqo reno on 4358.0 ± 242.7 4062.1 4733.3 1.00
neqo neqo reno 4010.0 ± 262.6 3608.9 4390.6 1.00
neqo neqo cubic on 4428.5 ± 347.2 3818.3 4986.0 1.00
neqo neqo cubic 4415.0 ± 269.5 4073.0 4921.1 1.00

⬇️ Download logs

@larseggert larseggert added this pull request to the merge queue Mar 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 28, 2024
@larseggert larseggert added this pull request to the merge queue Mar 28, 2024
Merged via the queue into mozilla:main with commit 3e12eae Mar 28, 2024
14 checks passed
@larseggert larseggert deleted the ci-fix-script branch March 28, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants