Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run cargo mutants on changed code #1742

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert marked this pull request as ready for review March 14, 2024 08:10
@larseggert larseggert enabled auto-merge March 14, 2024 08:10
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.48%. Comparing base (203987a) to head (5080c85).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1742   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files         126      126           
  Lines       38866    38866           
=======================================
  Hits        34780    34780           
  Misses       4086     4086           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark results

  • coalesce_acked_from_zero 1+1 entries
    time: [255.62 ns 258.31 ns 262.17 ns]
    change: [+1.7936% +2.4526% +3.2182%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 3+1 entries
    time: [291.62 ns 292.29 ns 293.00 ns]
    change: [+1.5244% +1.9163% +2.3279%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 10+1 entries
    time: [290.67 ns 291.66 ns 292.86 ns]
    change: [+1.2165% +1.8309% +2.3553%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 1000+1 entries
    time: [267.35 ns 267.52 ns 267.73 ns]
    change: [+2.7289% +3.3817% +4.0800%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • RxStreamOrderer::inbound_frame()
    time: [126.38 ms 126.55 ms 126.79 ms]
    change: [+3.5536% +3.7046% +3.8967%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • Run multiple transfers with varying seeds
    time: [190.17 ms 190.95 ms 191.72 ms]
    change: [-5.7319% -5.2613% -4.7611%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • Run multiple transfers with the same seed
    time: [191.76 ms 192.17 ms 192.59 ms]
    change: [-4.1570% -3.8891% -3.6255%] (p = 0.00 < 0.05)
    💚 Performance has improved.

⬇️ Download logs

Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do you have results from a baseline run that are interesting?

@larseggert larseggert added this pull request to the merge queue Mar 14, 2024
Merged via the queue into mozilla:main with commit 0f473b5 Mar 14, 2024
16 checks passed
@larseggert larseggert deleted the ci-mutants branch March 14, 2024 08:54
@larseggert
Copy link
Collaborator Author

It said a baseline run would take 12 hours... I'll run overnight.

@larseggert
Copy link
Collaborator Author

@martinthomson forgot to run the baseline, but this CI run has some results: https://github.com/mozilla/neqo/actions/runs/8281027735/job/22658686591#step:7:1

Found 3 mutants to test
 INFO Auto-set test timeout to 20s
ok       Unmutated baseline in 100.7s build + 1.9s test
caught   neqo-common/src/log.rs:57:5: replace init with () in 11.9s build + 1.2s test
MISSED   neqo-common/src/log.rs:77:32: replace == with != in init in 11.5s build + 1.4s test
MISSED   neqo-common/src/log.rs:58:9: replace init::do_init with () in 37.4s build + 0.7s test
3 mutants tested in 2m 22s: 2 missed, 1 caught

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants