-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Make criterion
calculate transfer benchmark throughputs
#1738
Conversation
Like: ``` transfer/Run multiple transfers with varying seeds time: [213.61 ms 224.95 ms 235.29 ms] thrpt: [17.000 MiB/s 17.782 MiB/s 18.726 MiB/s] change: time: [-17.204% -6.9690% +1.8324%] (p = 0.21 > 0.05) thrpt: [-1.7994% +7.4910% +20.778%] No change in performance detected. Found 5 outliers among 100 measurements (5.00%) 5 (5.00%) low mild transfer/Run multiple transfers with the same seed time: [175.41 ms 188.40 ms 201.32 ms] thrpt: [19.869 MiB/s 21.231 MiB/s 22.803 MiB/s] change: time: [-5.9393% +5.5417% +18.399%] (p = 0.35 > 0.05) thrpt: [-15.540% -5.2507% +6.3144%] No change in performance detected. Found 14 outliers among 100 measurements (14.00%) 8 (8.00%) low mild 5 (5.00%) high mild 1 (1.00%) high severe ```
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1738 +/- ##
=======================================
Coverage 89.48% 89.48%
=======================================
Files 126 126
Lines 38866 38866
=======================================
Hits 34780 34780
Misses 4086 4086 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I would observe that this isn't going to provide any indication of throughput in the congestion control sense, since these tests do not operate in real time. We're talking about raw packet production and consumption power here. That might be worth noting in the code.
(Approved in any case.)
Benchmark resultsPerformance differences relative to 2750423.
|
Like: