fix(client,server): re-enable clap default features #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When default features are disabled, clap does not e.g. generate logic for `--help` or `--version` handling. Instead it errors with the opaque error on anything other than correct command line flags. ``` $ neqo-client --version error: unexpected argument found ``` Instead of removing `default-features = false`, enable them individually. See https://docs.rs/clap/latest/clap/_features/index.html for details.
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
larseggert
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When default features are disabled, clap does not e.g. generate logic for
--helpor--versionhandling. Instead it errors with the opaque error on anything other than correct command line flags.Instead of removing
default-features = false, enable them individually.See https://docs.rs/clap/latest/clap/_features/index.html for details.