-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(github): qns comment on failure only and update existing #1720
Conversation
Once the QUIC Network Simulator workflow finished, the QUIC Network Simulator Comment workflow adds the test results as a comment to the corresponding pull request. This commit makes two changes: - Only add a comment on test failure. - In case a comment already exists, update it in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Note that the changes will only take effect once this pull request is merged. Thus I still expect a comment to be added to this pull request even if the QUIC Interop tests succeed. |
Download artifacts here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1720 +/- ##
=======================================
Coverage 92.98% 92.98%
=======================================
Files 120 120
Lines 37399 37399
=======================================
Hits 34775 34775
Misses 2624 2624 ☔ View full report in Codecov by Sentry. |
Once the QUIC Network Simulator workflow finished, the QUIC Network Simulator Comment workflow adds the test results as a comment to the corresponding pull request.
This commit makes two changes:
Parts of #1716.
Note I have not been able to test this yet. Happy to port this over to my test-setup https://github.com/mxinden/quic-interop-runner-action/ though that will take me a bit more time. Your call.