Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(.github): rename comment workflow #1715

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Mar 6, 2024

Rename Comment on the pull request to QUIC Network Simulator Comment.

Might be a bit more intuitive, when seeing it next to the other workflows:

image

Rename `Comment on the pull request` to `QUIC Network Simulator Comment`.
Copy link

github-actions bot commented Mar 6, 2024

QUIC Interop Runner

Saving logs to logs.
Run took 0:03:27.322433
Server: neqo-latest. Client: neqo-latest. Running test case: handshake
Server: quic-go. Client: neqo-latest. Running test case: handshake
Server: ngtcp2. Client: neqo-latest. Running test case: handshake
Server: neqo. Client: neqo-latest. Running test case: handshake
Server: msquic. Client: neqo-latest. Running test case: handshake
Server: neqo-latest. Client: quic-go. Running test case: handshake
Server: neqo-latest. Client: ngtcp2. Running test case: handshake
Server: neqo-latest. Client: neqo. Running test case: handshake
Server: neqo-latest. Client: msquic. Running test case: handshake
+-------------+-------------+---------+--------+------+--------+
|             | neqo-latest | quic-go | ngtcp2 | neqo | msquic |
+-------------+-------------+---------+--------+------+--------+
| neqo-latest |     ✓(H)    |   ✓(H)  |  ✓(H)  | ✓(H) |  ✓(H)  |
|             |     ?()     |   ?()   |  ?()   | ?()  |  ?()   |
|             |     ✕()     |   ✕()   |  ✕()   | ✕()  |  ✕()   |
+-------------+-------------+---------+--------+------+--------+
|   quic-go   |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+
|    ngtcp2   |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+
|     neqo    |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+
|    msquic   |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+

Download artifacts here.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.98%. Comparing base (c751b4e) to head (e6bd6bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1715   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         120      120           
  Lines       37399    37399           
=======================================
  Hits        34775    34775           
  Misses       2624     2624           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxinden
Copy link
Collaborator Author

mxinden commented Mar 6, 2024

Not sure whether the pull request comment (#1715 (comment)) adds more signal than noise in the long run. Happy to remove it, in case folks find it annoying. The important part for me is the CI check itself.

image

@larseggert larseggert added this pull request to the merge queue Mar 6, 2024
Merged via the queue into mozilla:main with commit 1a7e8fe Mar 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants