Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an error if the path is not permanent #1698

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Return an error if the path is not permanent #1698

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
baa9b52
Return an error if the path is not permanent
KershawChang Mar 1, 2024
a4db844
address comments
KershawChang Mar 12, 2024
1920679
address comments and make sure the test case really triggers the crash
KershawChang Mar 13, 2024
7f53105
clippy
KershawChang Mar 13, 2024
f7ab416
clippy again
KershawChang Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions neqo-transport/src/connection/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1937,6 +1937,10 @@
};

let path = close.path().borrow();
if path.is_temporary() {
debug_assert!(false, "Path is not permanent");
return Err(Error::InternalError);

Check warning on line 1942 in neqo-transport/src/connection/mod.rs

View check run for this annotation

Codecov / codecov/patch

neqo-transport/src/connection/mod.rs#L1941-L1942 

Added lines #L1941 - L1942 were not covered by tests
}
let (_, mut builder) = Self::build_packet_header(
&path,
cspace,
Expand Down
Loading