ci: Benchmark without a qlog #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To remove those overheads from the profile.
larseggert
requested review from
KershawChang and
martinthomson
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1648 +/- ##
==========================================
- Coverage 92.98% 92.92% -0.06%
==========================================
Files 119 119
Lines 37252 37212 -40
==========================================
- Hits 34638 34581 -57
- Misses 2614 2631 +17 ☔ View full report in Codecov by Sentry. |
|
Need to check the flamegraph whether this actually makes a difference. |
martinthomson
approved these changes
Feb 12, 2024
larseggert
commented
Feb 13, 2024
Signed-off-by: Lars Eggert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove those overheads from the profile.
This PR also rolls in some changes to the bencher, i.e., to make it generate flamegraphs and make them and the raw perf/criterion data available as build artifacts.