Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Build docker image for multiple architectures #1619

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

larseggert
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9260ba3) 87.33% compared to head (d0198d3) 87.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1619   +/-   ##
=======================================
  Coverage   87.33%   87.33%           
=======================================
  Files         124      124           
  Lines       39279    39279           
=======================================
  Hits        34305    34305           
  Misses       4974     4974           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larseggert
Copy link
Collaborator Author

@martinthomson any reason we're not building a new image every time main is updated? Would make it easier to run qnd locally with up-to-date images.

@mxinden
Copy link
Collaborator

mxinden commented Feb 5, 2024

@larseggert past comment by Martin on the topic: #1554 (comment)

I am in favor of a new image on each push to main.

@larseggert
Copy link
Collaborator Author

@mxinden any idea why https://github.com/mozilla/neqo/pkgs/container/neqo-qns under "OS / Arch" currently shows an unknown/unknown second image? Something wrong with the meta tags maybe?

@larseggert
Copy link
Collaborator Author

@martinthomson any reason we're not building a new image every time main is updated? Would make it easier to run qnd locally with up-to-date images.

Ah, nevermind! We have workflow_dispatch, so I can just have it build the image manually.

@larseggert larseggert merged commit 9a394e9 into mozilla:main Feb 5, 2024
2 of 3 checks passed
@larseggert larseggert deleted the ci-gns-multiarch branch February 5, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants