Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beta toolchain to CI #1520

Merged
merged 12 commits into from
Jan 2, 2024
Merged

Add beta toolchain to CI #1520

merged 12 commits into from
Jan 2, 2024

Conversation

larseggert
Copy link
Collaborator

And then let's see how to make it warn-only.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1639a4) 87.61% compared to head (a75bd3f) 87.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
- Coverage   87.61%   87.58%   -0.04%     
==========================================
  Files         117      117              
  Lines       37848    38072     +224     
==========================================
+ Hits        33160    33344     +184     
- Misses       4688     4728      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An early warning system is good, but we'll still be surprised by failures (esp. clippy). I don't see a good solution though.

@larseggert
Copy link
Collaborator Author

Yeah, I looked into downgrading all errors to warnings with clippy and I couldn't find a way.

@larseggert larseggert marked this pull request as ready for review January 2, 2024 09:45
@larseggert larseggert merged commit 5d1bca0 into main Jan 2, 2024
6 of 9 checks passed
@larseggert larseggert deleted the ci-add-beta branch January 2, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run rust beta in CI to see clippy warnings before they land in rust stable
3 participants