Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update indexmap requirement from 1.0 to 2.1 #1507

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 11, 2023

Updates the requirements on indexmap to permit the latest version.

Changelog

Sourced from indexmap's changelog.

  • 2.1.0

    • Empty slices can now be created with map::Slice::{new, new_mut} and set::Slice::new. In addition, Slice::new, len, and is_empty are now const functions on both types.

    • IndexMap, IndexSet, and their respective Slices all have binary search methods for sorted data: map binary_search_keys and set binary_search for plain comparision, binary_search_by for custom comparators, binary_search_by_key for key extraction, and partition_point for boolean conditions.

  • 2.0.2

    • The hashbrown dependency has been updated to version 0.14.1 to complete the support for Rust 1.63.
  • 2.0.1

    • MSRV: Rust 1.63.0 is now supported as well, pending publication of hashbrown's relaxed MSRV (or use cargo --ignore-rust-version).
  • 2.0.0

    • MSRV: Rust 1.64.0 or later is now required.

    • The "std" feature is no longer auto-detected. It is included in the default feature set, or else can be enabled like any other Cargo feature.

    • The "serde-1" feature has been removed, leaving just the optional "serde" dependency to be enabled like a feature itself.

    • IndexMap::get_index_mut now returns Option<(&K, &mut V)>, changing the key part from &mut K to &K. There is also a new alternative MutableKeys::get_index_mut2 to access the former behavior.

    • The new map::Slice<K, V> and set::Slice<T> offer a linear view of maps and sets, behaving a lot like normal [(K, V)] and [T] slices. Notably, comparison traits like Eq only consider items in order, rather than hash lookups, and slices even implement Hash.

    • IndexMap and IndexSet now have sort_by_cached_key and par_sort_by_cached_key methods which perform stable sorts in place using a key extraction function.

    • IndexMap and IndexSet now have reserve_exact, try_reserve, and try_reserve_exact methods that correspond to the same methods on Vec. However, exactness only applies to the direct capacity for items, while the raw hash table still follows its own rules for capacity and load factor.

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Dec 11, 2023
@larseggert
Copy link
Collaborator

larseggert commented Dec 19, 2023

FF uses its own patched version and 1.9.3, so unclear what to do here: https://searchfox.org/mozilla-central/source/Cargo.lock#2780-2796

@larseggert
Copy link
Collaborator

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/cargo/indexmap-2.1 branch from 0a34702 to f3a7fa6 Compare December 20, 2023 05:58
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1639a4) 87.61% compared to head (82749ad) 87.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
+ Coverage   87.61%   87.63%   +0.01%     
==========================================
  Files         117      117              
  Lines       37848    37848              
==========================================
+ Hits        33160    33167       +7     
+ Misses       4688     4681       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larseggert
Copy link
Collaborator

@dependabot rebase

Updates the requirements on [indexmap](https://github.com/bluss/indexmap) to permit the latest version.
- [Changelog](https://github.com/bluss/indexmap/blob/master/RELEASES.md)
- [Commits](indexmap-rs/indexmap@1.0.0...2.1.0)

---
updated-dependencies:
- dependency-name: indexmap
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/indexmap-2.1 branch from f3a7fa6 to 82749ad Compare December 20, 2023 09:56
@larseggert larseggert added the blocked Blocked on something else label Jan 2, 2024
@larseggert larseggert closed this Jan 16, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 16, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/indexmap-2.1 branch January 16, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on something else dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants