Skip to content

Commit

Permalink
fix(client,server): re-enable clap default features
Browse files Browse the repository at this point in the history
When default features are disabled, clap does not e.g. generate logic for
`--help` or `--version` handling. Instead it errors with the opaque error on
anything other than correct command line flags.

```
$ neqo-client --version

error: unexpected argument found
```

Instead of removing `default-features = false`, enable them individually.

See https://docs.rs/clap/latest/clap/_features/index.html for details.
  • Loading branch information
mxinden committed Mar 7, 2024
1 parent 1a7e8fe commit b210e48
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion neqo-client/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ workspace = true

[dependencies]
# neqo-client is not used in Firefox, so we can be liberal with dependency versions
clap = { version = "4.4", default-features = false, features = ["std", "derive"] }
clap = { version = "4.4", default-features = false, features = ["std", "color", "help", "usage", "error-context", "suggestions", "derive"] }
futures = { version = "0.3", default-features = false }
hex = { version = "0.4", default-features = false, features = ["std"] }
log = { version = "0.4", default-features = false }
Expand Down
2 changes: 1 addition & 1 deletion neqo-server/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ workspace = true

[dependencies]
# neqo-server is not used in Firefox, so we can be liberal with dependency versions
clap = { version = "4.4", default-features = false, features = ["std", "derive"] }
clap = { version = "4.4", default-features = false, features = ["std", "color", "help", "usage", "error-context", "suggestions", "derive"] }
futures = { version = "0.3", default-features = false, features = ["alloc"] }
log = { version = "0.4", default-features = false }
neqo-common = { path = "./../neqo-common", features = ["udp"] }
Expand Down

0 comments on commit b210e48

Please sign in to comment.