Skip to content

Commit

Permalink
fix(github): qns comment on failure only and update existing
Browse files Browse the repository at this point in the history
Once the QUIC Network Simulator workflow finished, the QUIC Network Simulator
Comment workflow adds the test results as a comment to the corresponding pull
request.

This commit makes two changes:

- Only add a comment on test failure.
- In case a comment already exists, update it in place.
  • Loading branch information
mxinden committed Mar 7, 2024
1 parent 1a7e8fe commit 8eb1c7b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/qns-comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ jobs:
pull-requests: write
runs-on: ubuntu-latest
if: >
github.event.workflow_run.event == 'pull_request'
github.event.workflow_run.event == 'pull_request' &&
github.event.workflow_run.conclusion == 'failure'
steps:
- name: Download comment-data
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -52,3 +53,4 @@ jobs:
with:
filePath: comment
pr_number: ${{ steps.pr-number.outputs.number }}
comment_tag: quic-network-simulator-comment

0 comments on commit 8eb1c7b

Please sign in to comment.