Skip to content

Commit

Permalink
feat: No zero-len CIDs for client
Browse files Browse the repository at this point in the history
They break the upcoming QNS migration tests.
  • Loading branch information
larseggert committed Oct 14, 2024
1 parent 944c817 commit 702949d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions neqo-bin/src/client/http09.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ use std::{
use neqo_common::{event::Provider, qdebug, qinfo, qwarn, Datagram};
use neqo_crypto::{AuthenticationStatus, ResumptionToken};
use neqo_transport::{
CloseReason, Connection, ConnectionEvent, EmptyConnectionIdGenerator, Error, Output, State,
CloseReason, Connection, ConnectionEvent, Error, Output, RandomConnectionIdGenerator, State,
StreamId, StreamType,
};
use url::Url;
Expand Down Expand Up @@ -137,7 +137,7 @@ pub fn create_client(
let mut client = Connection::new_client(
hostname,
&[alpn],
Rc::new(RefCell::new(EmptyConnectionIdGenerator::default())),
Rc::new(RefCell::new(RandomConnectionIdGenerator::new(10))),
local_addr,
remote_addr,
args.shared.quic_parameters.get(alpn),
Expand Down
6 changes: 3 additions & 3 deletions neqo-bin/src/client/http3.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ use neqo_common::{event::Provider, hex, qdebug, qinfo, qwarn, Datagram, Header};
use neqo_crypto::{AuthenticationStatus, ResumptionToken};
use neqo_http3::{Error, Http3Client, Http3ClientEvent, Http3Parameters, Http3State, Priority};
use neqo_transport::{
AppError, CloseReason, Connection, EmptyConnectionIdGenerator, Error as TransportError, Output,
StreamId,
AppError, CloseReason, Connection, Error as TransportError, Output,
RandomConnectionIdGenerator, StreamId,
};
use url::Url;

Expand Down Expand Up @@ -72,7 +72,7 @@ pub fn create_client(
let mut transport = Connection::new_client(
hostname,
&[&args.shared.alpn],
Rc::new(RefCell::new(EmptyConnectionIdGenerator::default())),
Rc::new(RefCell::new(RandomConnectionIdGenerator::new(10))),
local_addr,
remote_addr,
args.shared.quic_parameters.get(args.shared.alpn.as_str()),
Expand Down

0 comments on commit 702949d

Please sign in to comment.