Merge branch 'ci-bench-comment' of github.com:larseggert/neqo into ci…

…-bench-comment
mozilla · Mar 11, 2024 · 6174963 · 6174963
2 parents cb69be0 + ed0e057
commit 6174963
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/.github/actions/nss/action.yml b/.github/actions/nss/action.yml
@@ -16,23 +16,32 @@ inputs:
 runs:
   using: composite
   steps:
+    # Ideally, we'd use this. But things are sufficiently flaky that we're better off
+    # trying both hg and git. Leaving this here in case we want to re-try in the future.
+    #
     # - name: Checkout NSPR
     #   uses: actions/checkout@v4
     #   with:
     #     repository: "nss-dev/nspr"
     #     path: ${{ github.workspace }}/nspr
-
+    #
     # - name: Checkout NSS
     #   uses: actions/checkout@v4
     #   with:
     #     repository: "nss-dev/nss"
     #     path: ${{ github.workspace }}/nss
 
-    - run: hg clone https://hg.mozilla.org/projects/nspr ${{ github.workspace }}/nspr
+    - name: Checkout NSPR
       shell: bash
+      run: |
+        hg clone https://hg.mozilla.org/projects/nspr "${{ github.workspace }}/nspr" || \
+          git clone --depth=1 https://github.com/nss-dev/nspr "${{ github.workspace }}/nspr"
 
-    - run: hg clone https://hg.mozilla.org/projects/nss ${{ github.workspace }}/nss
+    - name: Checkout NSS
       shell: bash
+      run: |
+        hg clone https://hg.mozilla.org/projects/nss "${{ github.workspace }}/nss" || \
+          git clone --depth=1 https://github.com/nss-dev/nss "${{ github.workspace }}/nss"
 
     - name: Build
       shell: bash

diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml
@@ -136,7 +136,7 @@ jobs:
       - name: Format results as Markdown
         id: results
         run: |
-          grep -Ev 'ignored|running \d+ tests|%\)' output.txt |\
+          grep -Ev 'ignored|running \d+ tests|%\)' results.txt |\
             sed -E  -e 's/(Performance has regressed.)/:broken_heart: **\1**/gi' \
                     -e 's/(Performance has improved.)/:green_heart: **\1**/gi' \
                     -e 's/^ +/  * /gi' \

diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -46,7 +46,7 @@ jobs:
         env:
           DEBIAN_FRONTEND: noninteractive
         run: |
-          sudo apt-get install -y --no-install-recommends gyp ninja-build lld
+          sudo apt-get install -y --no-install-recommends gyp mercurial ninja-build lld
           echo "RUSTFLAGS=-C link-arg=-fuse-ld=lld" >> "$GITHUB_ENV"
 
       # In addition to installing dependencies, first make sure System Integrity Protection (SIP)
@@ -58,7 +58,7 @@ jobs:
         if: runner.os == 'MacOS'
         run: |
           csrutil status | grep disabled
-          brew install ninja llvm
+          brew install ninja mercurial llvm
           echo "/opt/homebrew/opt/llvm/bin" >> "$GITHUB_PATH"
           ln -s /opt/homebrew/bin/python3 /opt/homebrew/bin/python
           # python3 -m pip install gyp-next