Skip to content

Commit

Permalink
Try and comment
Browse files Browse the repository at this point in the history
  • Loading branch information
larseggert committed May 2, 2024
1 parent f813a69 commit 0661713
Showing 1 changed file with 29 additions and 4 deletions.
33 changes: 29 additions & 4 deletions .github/workflows/firefox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ concurrency:
jobs:
firefox:
name: Build Firefox
outputs:
artifacts: ${{ steps.export.outputs.artifact-url }}
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -123,14 +121,41 @@ jobs:
id: export
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
with:
name: ${{ runner.os }}-${{ env.FIREFOX }}-${{ matrix.type }}.tgz
name: ${{ matrix.os }}-${{ env.FIREFOX }}-${{ matrix.type }}.tgz
path: ${{ env.FIREFOX }}.tar
compression-level: 9

- run: echo "${{ steps.export.outputs.artifact-url }}" >> artifact

- name: Export artifact URL
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
with:
name: artifact-${{ matrix.os }}-${{ env.FIREFOX }}-${{ matrix.type }}
path: artifact

comment:
name: Comment on PR
runs-on: ubuntu-latest
needs: firefox
steps:
- uses: actions/download-artifact@9c19ed7fe5d278cd354c7dfd5d3b88589c7e2395 # v4.1.6
with:
pattern: 'artifact-*'
path: artifacts

- run: |

Check failure on line 146 in .github/workflows/firefox.yml

View workflow job for this annotation

GitHub Actions / actionlint

shellcheck reported issue in this script: SC2043:warning:3:13: This loop will only ever run once. Bad quoting or missing glob/expansion?

Check failure on line 146 in .github/workflows/firefox.yml

View workflow job for this annotation

GitHub Actions / actionlint

shellcheck reported issue in this script: SC2043:warning:5:17: This loop will only ever run once. Bad quoting or missing glob/expansion?

Check failure on line 146 in .github/workflows/firefox.yml

View workflow job for this annotation

GitHub Actions / actionlint

property "firefox" is not defined in object type {container: {id: string; network: string}; services: {string => {id: string; network: string; ports: {string => string}}}; status: string}
echo "${{ needs.firefox.outputs.artifacts}}"
{
echo "### Firefox builds for this PR"
for os in "${{ job.firefox.strategy.matrix.os }}"; do
echo -n "* **$os**:"
for type in "${{ job.firefox.strategy.matrix.type }}"; do
echo -n " [$type]($(cat artifacts/artifact-$os-${{ env.FIREFOX }}-$type))"
done
echo
done
} > comment.md
- uses: ./.github/actions/pr-comment-data-export
with:
name: firefox
contents: comment.md

0 comments on commit 0661713

Please sign in to comment.