Search for Darwin when Mac is selected #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iinh
reviewed
May 14, 2024
Comment on lines
43
to
46
| { key: '*', label: 'All OSes' }, | ||
| { key: 'Windows', label: 'Windows' }, | ||
| { key: 'Mac', label: 'Mac' }, | ||
| { key: 'Darwin', label: 'Mac' }, | ||
| { key: 'Linux', label: 'Linux' }, |
There was a problem hiding this comment.
Looking at this ingestion code, I think we're missing more than just Mac?
There was a problem hiding this comment.
Interesting. I did find a very small amount of BSD in the data. The thing is if we want to accommodate more than one name into a single alias, we have to do that at the ETL level, otherwise the aggregations won't make sense. I say we land this so ppl can look at Mac data and open an issue for your find?
There was a problem hiding this comment.
I agree. Maybe good to use this normalized os UDF at the ETL level - mozfun.norm.os(normalized_os).
There was a problem hiding this comment.
Perfect! Thanks for finding this. Would you mind opening the ticket with this precious info?
Iinh
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while testing other stuff. GLAM erroneously reporting no data for Mac metric all along because in the data it's called Darwin.