Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next): l10n: Update payments-next logic to use payments-next.ftl #18208

Merged
merged 1 commit into from
Jan 14, 2025
Merged

feat(next): l10n: Update payments-next logic to use payments-next.ftl #18208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions apps/payments/next/Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

module.exports = function(grunt) {
module.exports = function (grunt) {
const srcPaths = [
'.license.header',
'app/**/*.ftl',
Expand All @@ -26,10 +26,6 @@ module.exports = function(grunt) {
src: srcPaths,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its hard for me to tell if we still need this concat statement. It looks from reading the source code like it's still of use to us.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup it's still needed.

This grunt script creates the base payments-next.ftl file for base locale en which gets extracted by the l10n teams string extraction script, and passed on to Pontoon.

Additionally it also keeps the en/payments-next.ftl up to date during dev when new strings are added to the app.

dest: 'public/locales/en/payments-next.ftl',
},
ftlLegacy: {
src: srcPaths,
dest: 'public/locales/en/payments.ftl',
},
},
http: {
// Call the Payments Next route to restart and reinitialize the Nest App.
Expand Down Expand Up @@ -76,6 +72,6 @@ module.exports = function(grunt) {
grunt.loadNpmTasks('grunt-http');
grunt.loadNpmTasks('grunt-concurrent');

grunt.registerTask('merge-ftl', ['copy:branding-ftl', 'concat:ftl', 'concat:ftlLegacy']);
grunt.registerTask('merge-ftl', ['copy:branding-ftl', 'concat:ftl']);
grunt.registerTask('watchers', ['concurrent:dev']);
};
110 changes: 0 additions & 110 deletions apps/payments/next/app/_lib/scripts/convert.ts
View file
Open in desktop

This file was deleted.

Loading
Loading