Allow clients to set a log callback. #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutexlox-signal
force-pushed
the
mutexlox/log
branch
from
451b9d6
to
302f0c4
Compare
mutexlox-signal
force-pushed
the
mutexlox/log
branch
4 times, most recently
from
bfed05d
to
6d9e64c
Compare
|
Should be good with #100 merged no? |
mutexlox-signal
force-pushed
the
mutexlox/log
branch
from
6d9e64c
to
8e5d725
Compare
|
Yes, I think this is good to go now. thanks! |
|
I believe this is the last of my pending changes, so if you could please cut a release to crates.io after this is in (and we've confirmed CI is still passing) I would very much appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on mozilla/cubeb#802.no longer depends on a cubeb change.