-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updated the FACEBOOK_DOMAINS array to include additional domains… #943
base: main
Are you sure you want to change the base?
Conversation
… and sorted them alphabetically. Added the provided domains to the array and arranged them in ascending order for better organization and ease of reference. Signed-off-by: Ercan <[email protected]>
Hi @jeffguillaume, thank you for your approval. Best! 🙏🏻 |
@jeffguillaume Need another approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How have these domains been vetted? It looks like there are many additions.
Hi, I don't remember how I found them but we can check like below.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flightlesstux I love the single line break-up of the array. It's MUCH more readable.
Can you break please break this one PR into TWO PRs? (One with the new array layout and a second one introducing the new domains)
Adding extra domains can/may introduce unforeseen breakage. We are always extra cautious when adding domains, and we will need to independently verify Meta-ownership, etc. Thanks!
See mozilla#943 for context.
See mozilla#943 for context.
Updated the FACEBOOK_DOMAINS array to include additional domains and sorted them alphabetically. Added the provided domains to the array and arranged them in ascending order for better organization and ease of reference.