Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated the FACEBOOK_DOMAINS array to include additional domains… #943

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flightlesstux
Copy link

Updated the FACEBOOK_DOMAINS array to include additional domains and sorted them alphabetically. Added the provided domains to the array and arranged them in ascending order for better organization and ease of reference.

… and sorted them alphabetically. Added the provided domains to the array and arranged them in ascending order for better organization and ease of reference.

Signed-off-by: Ercan <[email protected]>
@flightlesstux
Copy link
Author

Hi @jeffguillaume, thank you for your approval. Best! 🙏🏻

@NeckBeardPrince
Copy link

@jeffguillaume Need another approval

Copy link

@jeffguillaume jeffguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How have these domains been vetted? It looks like there are many additions.

@flightlesstux
Copy link
Author

How have these domains been vetted? It looks like there are many additions.

Hi, I don't remember how I found them but we can check like below.

#!/bin/bash

# Domains list
domains=("accountkit.com" "acebook.com" "faacebook.com" "facebbook.com" "facebookcareers.com" "facebook.co" "facebook.com" "facebook.com.au" "facebook.com.mx" "facebook-dns.com" "facebookenterprise.com" "facebook-hardware.com" "facebook.it" "facebookmail.com" "facebook.net" "facebookrecruiting.com" "facebookstudy.com" "facebookvirtualassistant.com" "fb.audio" "fbcdn.net" "fb.com" "fbe2e.com" "fb.gg" "fbinfra.net" "fb.me" "fbpigeon.com" "fbsbx.com" "fbthirdpartypixel.com" "fb.watch" "fbwat.ch" "internet.org" "m-freeway.com" "parse.com" "wit.ai" "www.facebook.com" "fbcdn.com" "tfbnw.net" "facebook-web-clients.appspot.com" "fbcdn-profile-a.akamaihd.net" "fbsbx.com.online-metrix.net" "connect.facebook.net.edgekey.net" "facebookblueprint.com" "fburl.com" "internalfb.com" "cdninstagram.com" "instagramstatic-a.akamaihd.net" "instagramstatic-a.akamaihd.net.edgesuite.net" "messenger.com" "m.me" "messengerdevelopers.com" "facebook.messenger.com" "atdmt.com" "workplace.com" "www.workplace.com" "work.facebook.com" "onavo.com" "oculus.com" "oculusvr.com" "oculusbrand.com" "oculusforbusiness.com" "mapwith.ai" "mapillary.com" "oversightboard.com" "www.oversightboard.com" "bulletin.com" "facebookbrand.com" "metacareers.com" "meta.com" "metaque.st" "novi.com" "threads.net")

# Iterating through the domains list
for domain in ${domains[@]}; do
  # Get the IP address
  ip=$(dig +short $domain)
  
  # Print the IP address
  echo "$domain IP address: $ip"
  
  # Get the whois information
  whois_info=$(whois $ip | grep -i 'OrgName\|OrgId\|Address\|City\|StateProv\|PostalCode\|Country\|RegDate\|Updated\|Comment')

  # Print the whois information
  echo "$domain whois information: $whois_info"
  echo "--------------------------------------"
done

Copy link
Collaborator

@maxxcrawford maxxcrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flightlesstux I love the single line break-up of the array. It's MUCH more readable.

Can you break please break this one PR into TWO PRs? (One with the new array layout and a second one introducing the new domains)

Adding extra domains can/may introduce unforeseen breakage. We are always extra cautious when adding domains, and we will need to independently verify Meta-ownership, etc. Thanks!

@jdgp-hub jdgp-hub mentioned this pull request Aug 15, 2023
kevinsumner added a commit to kevinsumner/contain-facebook that referenced this pull request Jan 7, 2024
kevinsumner added a commit to kevinsumner/contain-facebook that referenced this pull request Jan 7, 2024
@kevinsumner
Copy link

kevinsumner commented Jan 7, 2024

I ran into this with fb.watch today, so I created #959 and #960 to address the feedback here, since this has been dormant for a few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants