Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #708 - Open PayPal inside the Facebook when donating #755

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxxcrawford
Copy link
Collaborator

Summary

This patch adds logic to open up a PayPal window inside the Facebook Container if the origin URL is https://facebook.com/donate and allows PayPal resources to be loaded inside Facebook Container.

Privacy Considerations:

  • Does this patch leak info for users who have both PayPal and Facebook accounts but do not connect services?
  • Current allowed resources from PayPal include a wild card for subdomains. Is that okay?

Testing Steps

  • Log into Facebook
    • Note - Make sure you do not have PayPal already connected as a funding source
  • Go to https://www.facebook.com/fundraisers/ and select any active campaign
  • Click "Donate" button
  • Under the Payment Method section, select "Connect to PayPal"
  • Click blue "Donate" button at the bottom of the form
  • EXPECTED: A separate PayPal window should open and be INSIDE the Facebook Container

@maxxcrawford maxxcrawford linked an issue Apr 22, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant donate with PayPal when Facebook Container installed
1 participant