Add Options/Settings Page Functionality #721

maxxcrawford · 2021-01-27T21:12:41Z

Features

This PR adds a preferences panel (accessible from both the add-on panel and the about:addons page). Beyond adding this space for future options/prefs, I added two options to start:

Allow Instagram data. This would allow IG embedded posts to load.
Turn off badging on non-Facebook pages. This would not put purple circles on login buttons, etc.

Resolved/mentioned issues:

Add prefereneces/options page #550

TODO

Localize all strings
Add editable* list of "contained" sites (Add prefereneces/options page #550)
- Editable allows you to remove contained sites only. There is no method to add sites. (Enhancement)
Set preference to close active tab if URL is changed to "contained" URL (Tab history is lost when openng #143)
- Behavior should match how this is handled on M-AC. Replace tab instead of creating a new one (#1765 #1704 #1590 #1837) multi-account-containers#1835
[x ] Style "Reset to Defaults" button
Use "Settings" every where. (No "preferences")

Testing

TBD

Screenshots

Gear Icon to open prefernces page:

about:addons preferences pane (WIP)

flodolo · 2021-01-28T07:09:19Z

src/_locales/en/messages.json

@@ -244,5 +244,9 @@
   "inPageUI-tooltip-button-share-passive": {
     "message": "If you click this button, Facebook will be able to track your visit to this site.",
     "description": ""
+   },
+   "fbcSettingsTitle": {
+     "message": "Preferences",


Firefox is moving to "Settings", is there a reason to use "Preferences"?

New title is "Optional Settings"

I've never seen the concept of "Pptional settings" outside of technical configuration files. What's the reasoning behind this choice, vs just "Settings"?

All of the settings are opt-in. I'm overthinking it. I'll switch it to "Settings"

One note: when on about:addons, and digging into the settings panel for a specific add-on, they use "Preferences"

One note: when on about:addons, and digging into the settings panel for a specific add-on, they use "Preferences"

That's probably worth a bug. I don't think the use of Settings was enforced, besides Firefox main Settings (previously Preferences/Options), but it would be nice to have consistency.

maxxcrawford

Self-review notes from sync review with @tcinotto

maxxcrawford · 2022-05-12T18:22:56Z

src/options.html

+              <input class="settings-checkbox" id="allowInstagram" type="checkbox" name="instagram" value="">
+              <div class="checkbox-copy">
+                <label for="allowInstagram">Allow Instagram to load outside of the Facebook container</label>
+                <p>This setting allows for embedded Instagram posts to load on websites outside of the Facebook Container. Note that enabling this setting may allow Facebook to track you across other websites.</p>


Move "Note that enabling this setting may allow Facebook to track you across other websites." to its own paragraph, highlighted with warning colors/treatment.

maxxcrawford · 2022-05-12T18:23:23Z

src/options.html

+              <input class="settings-checkbox" id="hideBadgeContent" type="checkbox" name="hideBadgeContent" value="">
+              <div class="checkbox-copy">
+                <label for="hideBadgeContent"><img class="inline-fbc-icon" src="fbc-icon.svg" alt=""> Hide FBC Badge </label>
+                <p>This setting hides the badge from appearing (including on hover) on Share/Login elements across non-Facebook sites.</p>


Add additional copy explaining that sites can still be added to the FB container via the panel

maxxcrawford · 2022-05-12T18:24:07Z

src/options.html

+              <input class="settings-checkbox" id="replaceTab" type="checkbox" name="replaceTab" value="">
+              <div class="checkbox-copy">
+                <label for="replaceTab">Open all Facebook-owned links in a new tab</label>
+                <p>This setting changes how opening Facebook-specific links behaves. The default behavior is to replace the current tab with the new link.</p>


Much larger conversation: With Facebook's parent company name change, should we reference "Meta" in some spots?

Suggested change

<p>This setting changes how opening Facebook-specific links behaves. The default behavior is to replace the current tab with the new link.</p>

<p>This setting changes how opening Meta-specific links behaves. The default behavior is to replace the current tab with the new link.</p>

…tings

…eset settings back to default

…ng the active tab, discarding the history state

…ll turned off.

…background.js, rather than unchecking/checking all the boxes.

…ly bbuild list of domains

…Facebook Container. (Treated the same way as about: pages)

… background color

…sites (both in the Settings and Doorhanger)

maxxcrawford added the WIP Work in progress label Jan 27, 2021

maxxcrawford changed the title ~~Settings Page/Options~~ Add Options/Settings Page Functionality Jan 27, 2021

flodolo reviewed Jan 28, 2021

View reviewed changes

This was referenced Feb 2, 2021

History Navigation work around #24

Open

Facebook Container's door-hanger does not respect the dark theme #597

Open

add panel for email fields to link to relay #700

Merged

maxxcrawford mentioned this pull request Mar 4, 2021

Very slow performance on page with Facebook Container extension enabled #601

Closed

maxxcrawford mentioned this pull request Mar 31, 2021

Not able do access workplace #676

Open

maxxcrawford force-pushed the settings-page branch from 3b8c629 to 5cd20d5 Compare May 11, 2022 21:26

maxxcrawford commented May 12, 2022

View reviewed changes

maxxcrawford requested review from groovecoder and codemist May 12, 2022 18:25

maxxcrawford marked this pull request as ready for review June 8, 2022 18:49

maxxcrawford added 17 commits June 8, 2022 13:51

Added Gear Icon to Panel

ba2cae3

Created options page and resources, registered in manifest

f0d45de

Added logic to toggle blocking Instagram resources

983a91b

Added logic to only run certain functions when necessary on updateSet…

5820994

…tings

WIP Commit

123a518

Add logic to show/hide badges based on user settings, add button to r…

a52ba4f

…eset settings back to default

Fix #143 - Add option to open links in a new tab, rather than replaci…

4cfb764

…ng the active tab, discarding the history state

Revise settings page from tooltip descriptions to subhead descriptions

7cc3d44

Revise all settings to be "opt-in" so that the default settings are a…

491ba7c

…ll turned off.

Revise reset settings button to query the default settings object in …

97ab5d0

…background.js, rather than unchecking/checking all the boxes.

Add domain manger feature to settings page

acf696d

Add remove site from allowed list function on options page, dymanical…

1396ca8

…ly bbuild list of domains

Add logic to not allow user user to add moz-extension:// page to the …

5daee71

…Facebook Container. (Treated the same way as about: pages)

Add feature to test the FavIcon, and if not found, replace with solid…

575e383

… background color

Fix JS error on internal (about:) pages

cad3242

Add functionality to dynamically build the default list of contained …

f37a4ee

…sites (both in the Settings and Doorhanger)

Add WhatsApp icon styles

556fb47

maxxcrawford added 3 commits June 8, 2022 13:53

Update button style to Nebula

b4dfd7d

Rebase fixups

8f14e3c

Add TODO comment

79eb79a

maxxcrawford force-pushed the settings-page branch from d7ae282 to 79eb79a Compare June 8, 2022 18:55

maxxcrawford removed the WIP Work in progress label Jun 8, 2022

maxxcrawford marked this pull request as draft June 8, 2022 18:57

maxxcrawford added the WIP Work in progress label Jun 8, 2022

maxxcrawford removed request for groovecoder and codemist June 8, 2022 18:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Options/Settings Page Functionality #721

Add Options/Settings Page Functionality #721

maxxcrawford commented Jan 27, 2021 •

edited

Loading

flodolo Jan 28, 2021

maxxcrawford May 11, 2022

flodolo May 12, 2022

maxxcrawford May 12, 2022

flodolo May 12, 2022

maxxcrawford left a comment

maxxcrawford May 12, 2022

maxxcrawford May 12, 2022

maxxcrawford May 12, 2022

	<p>This setting changes how opening Facebook-specific links behaves. The default behavior is to replace the current tab with the new link.</p>
	<p>This setting changes how opening Meta-specific links behaves. The default behavior is to replace the current tab with the new link.</p>

Add Options/Settings Page Functionality #721

Are you sure you want to change the base?

Add Options/Settings Page Functionality #721

Conversation

maxxcrawford commented Jan 27, 2021 • edited Loading

Features

TODO

Testing

Screenshots

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maxxcrawford left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maxxcrawford commented Jan 27, 2021 •

edited

Loading