Allow excluding prefixes for objects #1064
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a prefix is set, allow to not prefix specified objects. This is important e.g. when using 3rd Party objects in a Rust projects, that should not be renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I went ahead and opened a proposal to fix #1061. This would add a new config called
prefix_excludes, which allows to exclude objects from being prefixed, if a prefix is enabled. If this solution is not what you'd expect I'd be happy to discuss!Details
Usage would for example look like
This is something that would be greatly appreciated for the C API we're building in Qiskit, where cbindgen has proven to be very useful so far 🙂
I have no experience in committing to
cbindgen, I've added a test which produces the output I'm expecting, and I'm happy to add more things that are required for a PR.