Skip to content

Fix generic with "void" default #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Fix generic with "void" default #1063

merged 1 commit into from
May 14, 2025

Conversation

ogoffart
Copy link
Contributor

Fixes #993

facebook-github-bot pushed a commit to facebookexperimental/rust-shed that referenced this pull request Apr 8, 2025
Summary:
as titled, upgrade to 0.28 (https://github.com/mozilla/cbindgen/blob/master/Cargo.toml), which included previous patched PR
* mozilla/cbindgen#1006
* mozilla/cbindgen#1007

patch a new PR that includes another fix to unblock our work (D72418369)
* mozilla/cbindgen#1063

Reviewed By: chaos5958

Differential Revision: D72474788

fbshipit-source-id: b839aac0561c25eadffb01e5ad0699578cd51db2
facebook-github-bot pushed a commit to facebook/sapling that referenced this pull request Apr 8, 2025
Summary:
as titled, upgrade to 0.28 (https://github.com/mozilla/cbindgen/blob/master/Cargo.toml), which included previous patched PR
* mozilla/cbindgen#1006
* mozilla/cbindgen#1007

patch a new PR that includes another fix to unblock our work (D72418369)
* mozilla/cbindgen#1063

Reviewed By: chaos5958

Differential Revision: D72474788

fbshipit-source-id: b839aac0561c25eadffb01e5ad0699578cd51db2
facebook-github-bot pushed a commit to facebook/hhvm that referenced this pull request Apr 8, 2025
Summary:
as titled, upgrade to 0.28 (https://github.com/mozilla/cbindgen/blob/master/Cargo.toml), which included previous patched PR
* mozilla/cbindgen#1006
* mozilla/cbindgen#1007

patch a new PR that includes another fix to unblock our work (D72418369)
* mozilla/cbindgen#1063

Reviewed By: chaos5958

Differential Revision: D72474788

fbshipit-source-id: b839aac0561c25eadffb01e5ad0699578cd51db2
@emilio emilio added this pull request to the merge queue May 14, 2025
@emilio
Copy link
Collaborator

emilio commented May 14, 2025

Thank you!

Merged via the queue into mozilla:master with commit 0328601 May 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when parsing a generic type with empty tuple as default type parameter
2 participants