Skip to content

feat: Add support for constants defined with if + cfg! macro #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: Add support for constants defined with if + cfg! macro #1023

wants to merge 5 commits into from

Conversation

GrayJack
Copy link
Contributor

@GrayJack GrayJack commented Oct 27, 2024 •
edited
Loading

Fixes #1018

@GrayJack GrayJack force-pushed the const-if-cfg branch 2 times, most recently from a59e9f7 to d2977e8 Compare February 9, 2025 08:04
@GrayJack
Copy link
Contributor Author

GrayJack commented Feb 9, 2025

Turns out we can raise errors on expression position in Cython

@GrayJack GrayJack marked this pull request as ready for review February 9, 2025 08:36
@GrayJack
Copy link
Contributor Author

This branch was rebased with master latest changes, I believe this PR is ready to be reviewed

@GrayJack
Copy link
Contributor Author

GrayJack commented Apr 6, 2025

Rebased once more to fix conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Handle if + cfg! in const context
1 participant
@GrayJack