Skip to content

MNTOR-4291 + MNTOR-4290 - Bundle Announcements #5919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

MNTOR-4291 + MNTOR-4290 - Bundle Announcements #5919

wants to merge 7 commits into from

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented May 22, 2025 •
edited
Loading

References:

Jira: MNTOR-4291 + MNTOR-4290
Figma: https://www.figma.com/design/KytF3NIQfR8OoWu0osldg7/Privacy-Products-Bundle-Specs?node-id=10162-42539&t=erP1TkZBHCnq5llt-4

Description

Screenshot (if applicable)

Not applicable.

How to test

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@codemist codemist changed the title MNTOR-4291 - Bundle Announcements Strings MNTOR-4291 - Bundle Announcements May 22, 2025
@codemist codemist marked this pull request as ready for review May 22, 2025 20:37
@codemist codemist requested a review from flodolo as a code owner May 22, 2025 20:37
@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5919-mgjlpikfea-uk.a.run.app

@codemist codemist requested a review from Vinnl May 23, 2025 18:02
codemist
codemist commented May 23, 2025
View reviewed changes
src/app/(proper_react)/layout.tsx
<PromptNoneAuth />
)}
{children}
<SubscriptionBillingProvider value={billing}>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve introduced a SubscriptionBillingProvider so we only read our subscription pricing once on the server and make it available everywhere via useSubscriptionBilling(). This removes the need to pass bundleMonthlyPrice through every <LocalizedAnnouncementString />, keeps component props clean.

@codemist codemist requested a review from flozia May 23, 2025 19:06
@codemist codemist changed the title MNTOR-4291 - Bundle Announcements MNTOR-4291 + MNTOR-4298 - Bundle Announcements May 23, 2025
@codemist codemist changed the title MNTOR-4291 + MNTOR-4298 - Bundle Announcements MNTOR-4291 + MNTOR-4290 - Bundle Announcements May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flodolo flodolo flodolo approved these changes

@Vinnl Vinnl Awaiting requested review from Vinnl

@flozia flozia Awaiting requested review from flozia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codemist @flodolo